Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD-3563: Regression Suite PAC hashed MBIs query is returning no data resulting in failing tests #2407

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

malessi
Copy link
Contributor

@malessi malessi commented Aug 20, 2024

JIRA Ticket:
BFD-3563

What Does This PR Do?

This PR replaces the now-defunct PAC hashed MBIs query with a new query courtesy of @aschey-forpeople and @mjburling that returns usable data for our Claim and ClaimResponse Regression Suite tests.

Note that the query is limited to 300 results as the Regression Suites cycle through the returned data, so the MBIs will never be exhausted. This is fine for this type of test as we're strictly looking for regressions in performance due to code changes.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

  • Running the v2 Regression Suite locally against test, prod-sbx, and prod, verifying that:
    • 300 results are returned in all environments
    • The Claim and ClaimResponse regression tests work as expected and no errors were observed
    • The query finishes within a reasonable time (<1 second in test and prod-sbx, 1-2 seconds in prod)

@malessi malessi marked this pull request as draft August 20, 2024 22:36
@malessi malessi marked this pull request as ready for review August 20, 2024 22:42
@malessi malessi enabled auto-merge (squash) August 20, 2024 22:43
@malessi malessi merged commit 1b5581c into master Aug 21, 2024
7 checks passed
@malessi malessi deleted the alessio/BFD-3563__fix-pac-regression-tests branch August 21, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants