BFD-3566: Add materialized view for tracking the current beneficiary for an xref group #2398
+103
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschey-forpeople
requested review from
mjburling,
dondevun,
meliGuzman and
malessi
as code owners
meliGuzman
reviewed
Aug 7, 2024
...pipeline/bfd-pipeline-ccw-rif/src/main/java/gov/cms/bfd/pipeline/ccw/rif/load/RifLoader.java
Show resolved
Hide resolved
meliGuzman
approved these changes
Aug 8, 2024
aschey-forpeople
commented
Aug 8, 2024
| /** Refreshes the current beneficiaries materialized view. */ | ||
| private void refreshCurrentBeneficiariesView() { | ||
| try (EntityManager entityManager = appState.getEntityManagerFactory().createEntityManager()) { | ||
| try (final Timer.Context timerRefreshCurrentBeneficiaries = |
There was a problem hiding this comment.
There's a filter to prevent these metrics from being published to CloudWatch if we don't need to create alarms off of them so we don't incur the additional costs. We can see this data in New Relic instead (unit here is nanoseconds so the value here is 0.28 seconds)
dondevun
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3566
What Does This PR Do?
ccw.current_beneficiariesthat tracks the current beneficiary for each xref group (see comments in SQL file for details)What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Tested in an ephemeral environment - re-ran the pipeline load, ensured view was refreshed.