-
Notifications
You must be signed in to change notification settings - Fork 36
Add class RecHitCommonMode #7
base: FNAL_TB_16Layers
Are you sure you want to change the base?
Add class RecHitCommonMode #7
Conversation
// class declaration | ||
// | ||
|
||
enum CellType{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CellType should already be defined in some header file.
Dear Menglei, thanks for the module. Can we discuss and fix the small issues I pointed out? |
@shervin86 Let me know if anything else need to be modified/added. cheers, |
Hi Menglei, The cellType is one of the parameters that define a Det Id. So for a unique Thus post unpacking the digis and the rechits for that matter have the If we agree that having a int -> char[]/string map is more convenient thanks, On Mon, Aug 29, 2016 at 8:44 AM, mengleisun [email protected]
Rajdeep.Mohan.Chatterjee |
Hi all, I have change the input argument of the getCommonModeNoise() function to DetId. @shervin86, would you like me to remove the enum type of cellType, or keep it / move it to somewhere else? thanks, |
new branch with partial modifications: mergingPR7 |
Add a class "RecHitCommonMode" to estimate the common mode noise.
A new plugin "RecHitPlotter_HighGain_CM_Correction.cc" was created to illustrate the use of the RecHitCommonMode class.
test_cfg_2.py was modified based on the test_cfg.py to test the new plugin.