Fix a bug related with Sys-Init-V #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we use a option `serviceType` to control the type of service, the value can be `systemd` or `sys-init-v`, which means we now can use `systemd` to deploy in the docker if `systemd` is supported in the docker. Besides, we remove two unused options. What's more, we update the script for `sys-init-v`, the old one has some problems: it can not redirect the output to the log file, all the output was redirected to the `PIDFILE`, so we just fix this. And, for creating `git` user, there may be no `/home/git/.ssh`, so we add a `mkdir` command to create it.
Kaiser-Yang
force-pushed
the
kaiser-doc
branch
from
daeac0c
to
71b7382
Compare
Kaiser-Yang
requested review from
luckygalaxy666,
ajiankexx,
Liu-shui-chan-yuan,
propanone1006,
Quentin9922 and
11231f
and removed request for
luckygalaxy666
luckygalaxy666
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we use a option
serviceTypeto control the type of service, the value can besystemdorsys-init-v, which means we now can usesystemdto deploy in the docker ifsystemdis supported in the docker. Besides, we remove two unused options. What's more, we update the script forsys-init-v, the old one has some problems: it can not redirect the output to the log file, all the output was redirected to thePIDFILE, so we just fix this. And, for creatinggituser, there may be no/home/git/.ssh, so we add amkdircommand to create it.