tls.cc precisely_bound_buffer representation fix #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rmn30 points out that just because the requested length is shorter than the maximum representable length doesn't mean that it's representable. Round the requested length down by the alignment mask first! Co-authored-by: Robert Norton <[email protected]>
|
Can you expand the comment? I’m not sure I understand the masking. |
|
Sure thing. I'll copy commentary from CHERIoT-Platform/cheriot-sail#74 |
|
OBE; see #38. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rmn30 points out that just because the requested length is shorter than the maximum representable length doesn't mean that it's representable. Round the requested length down by the alignment mask first!