Implementation of HDS in SUMMA #568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martynpclark, please review this. I can't add you as a reviewer to this PR because I don't have permission. |
|
I can include the test step I have been experimenting with (if that's helpful). |
martynpclark
reviewed
Jun 4, 2024
| real(rkind) :: depressionVol ! depression volume [m3] | ||
| !***************************************** | ||
| ! initialize HDS pothole storage variables | ||
| ! GRU level |
There was a problem hiding this comment.
Consider updating to new refactored code standards that are currently being developed
There was a problem hiding this comment.
| @@ -391,7 +397,51 @@ subroutine read_icond(iconFile, & ! intent(in): name of | |||
| ! -------------------------------------------------------------------------------------------------------- | |||
| ! (2) now get the basin variable(s) | |||
| ! -------------------------------------------------------------------------------------------------------- | |||
|
|
|||
| !******************************** | |||
There was a problem hiding this comment.
Can this code be generalized?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial implementation of the Hysteretic Depressional Storage (HDS) algorithm for prairie potholes in the SUMMA model.
The model has been tested under different I/O configurations and works as expected on a hypothetical test case.
To activate the HDS model, the following has to be done:
a model decision must be defined to activate HDS as:
The following HDS parameters must be defined at the GRU (basin) level in the
zParamTrial.ncfile (if the parameters are spatially variable) or in theBasinParamInfo.txtif they are spatially constant. The following is an example of dummy parameters value.pondVolFracat the GRU level in thezInitialCond.nc