Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduction of the use of rtemplate #445

Merged
merged 33 commits into from
Sep 4, 2023

Conversation

llaniewski
Copy link
Member

This PR introduces a "Model" abstract class which provides all model related data.frames in C++ containers that are easy to iterate over. This allows for all Handlers, and some other parts of code to not rely on rtemplate code generation to function.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Patch coverage: 43.25% and project coverage change: +0.21% 🎉

Comparison is base (826ebf4) 44.08% compared to head (a7659dc) 44.30%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #445      +/-   ##
===========================================
+ Coverage    44.08%   44.30%   +0.21%     
===========================================
  Files          166      169       +3     
  Lines         7821     7887      +66     
===========================================
+ Hits          3448     3494      +46     
- Misses        4373     4393      +20     
Flag Coverage Δ
d2q9 30.38% <33.48%> (-0.17%) ⬇️
d2q9_bc 26.67% <25.38%> (-0.14%) ⬇️
d2q9_kuper 27.44% <30.98%> (-0.07%) ⬇️
d3q27_PSM_NEBB 36.00% <36.95%> (+0.28%) ⬆️
d3q27_pf_velocity 30.44% <36.73%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Handlers/BSpline.cpp 0.00% <ø> (ø)
src/Handlers/IfContainer.cpp 0.00% <0.00%> (ø)
src/Handlers/IfContainer.h 0.00% <ø> (ø)
src/Handlers/OptimalControl.cpp 0.00% <0.00%> (ø)
src/Handlers/OptimalControlSecond.cpp 0.00% <0.00%> (ø)
src/Handlers/acObjective.cpp 0.00% <0.00%> (ø)
src/Handlers/acOptimize.cpp.Rt 26.66% <ø> (ø)
src/Handlers/acRunAction.cpp 0.00% <0.00%> (ø)
src/Handlers/acThreshold.cpp 0.00% <0.00%> (ø)
src/Handlers/acThresholdNow.cpp 0.00% <0.00%> (ø)
... and 31 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@llaniewski llaniewski merged commit 7216c6c into CFD-GO:develop Sep 4, 2023
47 checks passed
@llaniewski llaniewski mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants