Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the SolidGrid print issue #442

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

llaniewski
Copy link
Member

No description provided.

@llaniewski
Copy link
Member Author

@ndivaira This should solve the issue with excessive printing and reconstruction of the SolidGrid indexer. I'll merge after all the tests complete.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.02% 🎉

Comparison is base (769d4b7) 43.98% compared to head (52a74fb) 44.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #442      +/-   ##
===========================================
+ Coverage    43.98%   44.00%   +0.02%     
===========================================
  Files          166      166              
  Lines         7801     7808       +7     
===========================================
+ Hits          3431     3436       +5     
- Misses        4370     4372       +2     
Flag Coverage Δ
d2q9 30.42% <100.00%> (+0.02%) ⬆️
d2q9_bc 26.68% <100.00%> (+0.02%) ⬆️
d2q9_kuper 27.38% <100.00%> (+0.02%) ⬆️
d3q27_PSM_NEBB 35.60% <44.44%> (+<0.01%) ⬆️
d3q27_pf_velocity 30.33% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tests/solid/main.cpp 70.10% <ø> (ø)
src/SolidGrid.hpp 89.61% <71.42%> (-2.18%) ⬇️
src/SolidGrid.h 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@llaniewski llaniewski merged commit c207d33 into CFD-GO:develop Aug 18, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants