Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid Container #435

Merged
merged 35 commits into from
Aug 3, 2023
Merged

Solid Container #435

merged 35 commits into from
Aug 3, 2023

Conversation

llaniewski
Copy link
Member

Introducing new mechanics for Solid/Particle containers and iterating over particles.
Additionally this PR cleans up the legacy mess with atomic reductions.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage: 82.70% and project coverage change: +1.48% 🎉

Comparison is base (9a06be7) 42.69% compared to head (cd760c9) 44.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #435      +/-   ##
===========================================
+ Coverage    42.69%   44.18%   +1.48%     
===========================================
  Files          159      163       +4     
  Lines         7504     7777     +273     
===========================================
+ Hits          3204     3436     +232     
- Misses        4300     4341      +41     
Flag Coverage Δ
d2q9 30.44% <18.64%> (-0.16%) ⬇️
d2q9_bc 26.78% <15.25%> (-0.13%) ⬇️
d2q9_kuper 27.62% <16.66%> (-0.13%) ⬇️
d3q27_PSM_NEBB 35.73% <77.77%> (+0.06%) ⬆️
d3q27_pf_velocity 30.41% <22.58%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Handlers/cbRunR.cpp.Rt 66.66% <ø> (ø)
src/Lattice.h.Rt 64.28% <ø> (ø)
src/LatticeAccess.inc.cpp.Rt 100.00% <ø> (ø)
src/LatticeContainer.h.Rt 83.33% <ø> (ø)
src/LatticeContainer.inc.cpp.Rt 63.40% <ø> (ø)
src/Particle.hpp 64.70% <45.45%> (-15.05%) ⬇️
tests/solid/main.cpp 70.10% <70.10%> (ø)
src/cross.h 75.00% <75.00%> (-12.50%) ⬇️
src/SolidGrid.hpp 91.78% <91.78%> (ø)
models/particles/d3q27_PSM/Dynamics.c.Rt 31.66% <100.00%> (+0.38%) ⬆️
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@llaniewski llaniewski self-assigned this Jun 6, 2023
@llaniewski llaniewski added enhancement New features/updates DEM related to particle dynamics labels Jun 6, 2023
@llaniewski llaniewski changed the base branch from master to develop July 30, 2023 23:55
@llaniewski llaniewski merged commit d376bb6 into CFD-GO:develop Aug 3, 2023
47 checks passed
@llaniewski llaniewski deleted the feature/fastdem branch August 3, 2023 02:26
@llaniewski llaniewski mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEM related to particle dynamics enhancement New features/updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants