Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resample #59

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Resample #59

wants to merge 7 commits into from

Conversation

fcollman
Copy link
Collaborator

This adds a function to resample skeletons (while dropping non root connected components)

@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #59 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #59     +/-   ##
=========================================
+ Coverage   76.24%   76.65%   +0.4%     
=========================================
  Files          12       12             
  Lines        1945     1979     +34     
=========================================
+ Hits         1483     1517     +34     
  Misses        462      462
Impacted Files Coverage Δ
meshparty/skeleton.py 93.38% <100%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be0591...0f97325. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #59 (0f97325) into master (b77b829) will increase coverage by 20.60%.
The diff coverage is 100.00%.

❗ Current head 0f97325 differs from pull request most recent head 15edb71. Consider uploading reports for the commit 15edb71 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master      #59       +/-   ##
===========================================
+ Coverage   56.04%   76.65%   +20.60%     
===========================================
  Files          23       12       -11     
  Lines        4102     1979     -2123     
===========================================
- Hits         2299     1517      -782     
+ Misses       1803      462     -1341     
Impacted Files Coverage Δ
meshparty/skeleton.py 93.38% <100.00%> (+5.42%) ⬆️
meshparty/mesh_skel_utils.py 84.21% <0.00%> (-1.51%) ⬇️
meshparty/spatial_annotations.py
meshparty/ray_tracing.py
meshparty/skeleton_quality/skeleton_quality.py
meshparty/meshwork/meshwork.py
meshparty/meshwork/__init__.py
meshparty/meshwork/algorithms.py
meshparty/meshwork/utils.py
meshparty/skeleton_quality.py
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77b829...15edb71. Read the comment docs.

@ceesem
Copy link
Collaborator

ceesem commented May 21, 2021

Looks good to me. The new skeleton creation is a good approach since it makes adding features like updating the mesh map, etc, purely additive.

@ceesem
Copy link
Collaborator

ceesem commented May 21, 2021

One caveat: it looks to me like it will break if the skeleton is masked such that the root is not in the mask (this is allowed because I have a static skeleton "underneath" the maskable skeleton). I think that's okay to disallow this, but maybe it should be explicitly tested for and rejected.

@fcollman fcollman closed this Aug 26, 2022
@fcollman fcollman reopened this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants