Remove ESM15 special case related to lnonwood condition on dNplantdt(wood) #434
+13
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
Non-ESM15 code versions had a condition on the calculation of dNplantdt(:.wood) to only do the calculation for woody pfts, having first set it to zero for all pfts. An ifndef was used to ignore the condition when ESM15 was defined YES.
The was no apparent reason why ESM15 could not use the condition so the special case was removed.
For clarity the condition was re-written as an IF/THEN.
dPplantdt(:,wood) is calculated in the same way as dNplantdt but had no condition. For consistency, a similar condition has been added so that nitrogen and phosphorus are treated the same way.
Fixes #423
Type of change
Please delete options that are not relevant.
Checklist
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--434.org.readthedocs.build/en/434/