Correct array constructor for strings in CABLE-POP_TRENDY

[mcuntz]

CABLE

Description

The model did not compile with gfortran v14.2.

Possible dimension names in input files are defined as a character arrays in cable_common_module. They have different character lengths. The current notation is not Fortran standard compliant. I replaced

CHARACTER(LEN=16), DIMENSION(5), PARAMETER :: LatNames = &
    ["latitude", "lat", "lats", "y", "Latitude"]

with

CHARACTER(LEN=*), DIMENSION(*), PARAMETER :: LatNames = &
    [CHARACTER(LEN=8) :: "latitude", "lat", "lats", "y", "Latitude"]

Same for LonNames and TimeNames.
I found this very cool notation on stackoverflow.

Another error was also in cable_common, where the continuation character was within the string:

CALL handle_err(ok, "Failed to find any "//TRIM(DimNames(1))//" dimensions&
    from the list.")

The compiler does not know if & is part of the string or the continuation character. I pulled it out of the string.

I also extended VarNames in spatio_temporal_dataset from 16 to length 32 because they are used currently only in cable_cru_Trendy and the names used there had a maximum of 32 characters.

I finally compiled with debug flags, made both arguments of Fortran intrinsics (min) the same kind, removed all unused variables and unused module variables mainly in cable_input and casa_inout.

I would suggest adding '-e03' to the Intel debug flags for better standard compliance. I have not tested that and have not changed CMakeLists.txt.

Type of change

• Bug fix

Checklist

• The new content is accessible and located in the appropriate section.
• I have checked that links are valid and point to the intended content.
• I have checked my code/text and corrected any misspellings

[Whyborn]

Can you give a link to the documentation on that -e03 compiler flag? I can't find anything on it at the Intel Compiler Flag list.