Updating 219 from main. #426

This is done so that: 1. We can create separate targets for the serial and MPI executable and only link against the MPI libraries when needed without relying on the MPI compiler wrapper. This lets us compile all executables (serial and parallel) with a single invocation of CMake. 2. We can use object libraries to compile the object files common to both serial and MPI builds. This saves compiling these object files for each executable (serial and MPI), reducing compilation time. Note: since compiler flags are the same across all targets, this change applies the flags globally to all targets in the current directory and below via [`add_compile_options`][add_compile_options]. [add_compile_options]: https://cmake.org/cmake/help/latest/command/add_compile_options.html

Flags for release and debug configurations for the GNU compiler were taken from build.ksh (CABLE-POP_TRENDY branch).

This pull request should follow after the CMake implementation (see #200). This change adds the following build system changes: - List source files in alphabetical order in CMakeLists.txt. The order of source files was previously chosen so that we could demonstrate binary equivalence in executables between the CMake build and the Makefile build. - Use [`find_package(MPI REQUIRED)`](https://cmake.org/cmake/help/latest/module/FindMPI.html) instead of specifying `mpif90` when invoking `cmake` for MPI case. This is done so that 1. We can create separate targets for the serial and MPI executable and only link against the MPI libraries when needed without relying on the MPI compiler wrapper. This lets us compile all executables (serial and parallel) with a single invocation of CMake. 2. We can use object libraries to compile the object files common to both serial and MPI builds. This saves compiling these object files for each executable (serial and MPI), reducing compilation time. - Portability fixes and improvements to build.bash. - Add `--compiler` flag to build.bash and GNU compiler support. - Add Matthias's configuration for example. Regression tests using [benchcab](https://github.com/CABLE-LSM/benchcab)* (bitwise comparison of model output via nccmp) show that model output is bitwise identical between the current branch and the main branch for serial and MPI model runs. *executables were built manually as benchcab does not yet support the recent build system changes (see related issue: CABLE-LSM/benchcab#258). Fixes #215  ---- 📚 Documentation preview 📚: https://cable--216.org.readthedocs.build/en/216/

Making CABLE available as a [spack](https://spack.io/) package allows us to test the model compiles successfully inside a continuous integration (CI) environment which gets triggered automatically on a pull request. This change adds the model build CI workflow developed by the ACCESS-NRI release team to compile CABLE offline via spack (see [build-ci](https://github.com/ACCESS-NRI/build-ci) for more details). This workflow compiles CABLE using the intel compiler. The CI for other compilers will follow after this pull request. Fixes #202  ---- 📚 Documentation preview 📚: https://cable--223.org.readthedocs.build/en/223/

# CABLE ground water hydrology work of Mengyuan Mu This pull request is part of integrating the ground water hydrology work of Mengyuan Mu into CABLE, which will take place in a sequence of pull requests. The actual integration project itself was completed back in September 2023. The current work involves just a gradual merge into the main branch. ## Description 1. A new SUBROUTINE GWspatialParameters is introduced in **src/offline/cable_parameters.F90** 2. This subroutine will eventually be called only once, from **src/offline/cable_input.F90**. I will add this call at the appropriate time, but for now the subroutine is inactive 3. Dependencies are introduced in **src/offline/cable_parameters.F90** and **src/offline/cable_define_types.F90** in order for the code to compile successfully (confirmed) 4. This pull request involves only code additions, no deletions or modifications of existing code were carried out (some minor typos I came across in existing comments were fixed) 5. *PLEASE* do not delete any of my in-code comments (tagged rk4417) for now. Once the integration of the ground water hydrology work is complete and its functionality is confirmed to reproduce the results obtained already outside of the repo, I will clean-up all of my comments in a single pull request. Deleting any of my comments now will just make it much more difficult for me to track down and fix any issues that might arise during this process.  ---- 📚 Documentation preview 📚: https://cable--224.org.readthedocs.build/en/224/

# CABLE ## Description gfortran could not compile the CABLE main branch, neither in release mode (-O3 -Wno-aggressive-loop-optimizations) nor in debug mode (-O -g -pedantic-errors -Wall -W -Wno-maybe-uninitialized -fbacktrace -ffpe-trap=zero,overflow,underflow -finit-real=nan). The name `mland` was an ambiguous reference in the routine `landuse_allocate_mland` in landuse3.F90 because it is used via landuse_constant and defined in `landuse_allocate_mland`. I renamed it locally to `imland` in the routine. With this change, the release mode compiled. However there were plenty of 'Nonconforming tab character' and 'continued character constant' in the other files. I removed all that and now it compiles in release and debug mode. ## Type of change Please delete options that are not relevant. - [x] Bug fix - [ ] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--221.org.readthedocs.build/en/221/

The build script currently does not support MPI builds with the GNU compiler on Gadi. This is due to the `intel-mpi` module being loaded when we should be using an MPI module that is compatible with the chosen compiler. This change loads the `openmpi` module when GNU compilation is enabled in the build script. Fixes #239  ---- 📚 Documentation preview 📚: https://cable--241.org.readthedocs.build/en/241/

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Fixes #(285) Change Uber Quick guide instructions to run the testcase from src/offline/ since for now CABLE needs the namelists in the run directory. ## Type of change Please delete options that are not relevant. - [X] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--286.org.readthedocs.build/en/286/

Case of mobile is not a major consideration here, comfort on a computer is more important

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Increase the overall width of the page. This removes the large left and right margins and tend to improve the rendering of the tables throughout the documentation. You can link issues by using a supported keyword in the pull request's description or in a commit message: Fixes #(303) ## Type of change Please delete options that are not relevant. - [X] New or updated documentation ## Checklist - [X] The new content is accessible and located in the appropriate section. - [X] I have checked that links are valid and point to the intended content. - [X] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--305.org.readthedocs.build/en/305/

# CABLE Resolves #298 Recently, the [documentation](https://squidfunk.github.io/mkdocs-material/reference/math/#mathjax) for MathJax changed to reset the typeset after instant page load. Considering that it's a cache issue, we would know for sure that the effect after it's on the main `readthedocs` is built again. Seems to work well for readthedocs PR preview (although they do hard refresh for every new page load) Relevant issues - squidfunk/mkdocs-material#6661 - squidfunk/mkdocs-material#6407  ---- 📚 Documentation preview 📚: https://cable--304.org.readthedocs.build/en/304/

Co-authored-by: Claire Carouge <[email protected]>

## Description Updated content of pft_params.nml options under User Guide as a side task of another GW-related task. Added text and tables to provide more and neater content. ## Type of change - [ ] New or updated documentation  ---- 📚 Documentation preview 📚: https://cable--299.org.readthedocs.build/en/299/

Comment alignment Co-authored-by: Claire Carouge <[email protected]>

…#308) # CABLE Thank you for submitting a pull request to the CABLE Project. ## Description The model crashed when trying to run multiple sites in the met data file. This was because ncid_mask was not defined. Fixes #306 ## Type of change Please delete options that are not relevant. - [X ] Bug fix ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--308.org.readthedocs.build/en/308/

Issues in the [build-ci](https://github.com/ACCESS-NRI/build-ci) pipeline have now been fixed. This change updates the build-ci version to incorporate these changes. Fixes #236  ---- 📚 Documentation preview 📚: https://cable--271.org.readthedocs.build/en/271/

Fixes #293

Fixes #295

Fixes #292

Fixes #294

Fixes #311

…cases Fixes #312

This PR addresses feedback specific to build.bash raised in PR: #238 Fixes #296  ---- 📚 Documentation preview 📚: https://cable--297.org.readthedocs.build/en/297/

Co-authored-by: Claire Carouge <[email protected]>

# CABLE ## Description Added more structure and documentation to the user guide, together with a few placeholders to be filled soon. - [X ] New or updated documentation  ---- 📚 Documentation preview 📚: https://cable--315.org.readthedocs.build/en/315/

Fixes #225 Add 2 flags to range checks ``` check%ranges (0, 1, 2) - When to do the range checks NO_CHECK, ON_TIMESTEP, ON_WRITE check%exit (.true., .false.) - Whether to exit the program if range checks are done, and out of range - the other option is to provide a warning ``` - Checks are being done in the following stages 1. Parameters of `soil` and `veg` before running the spinloop 2. Parameters when creating the NetCDF output file (some of them clash with `soil` and `veg` but code can be refactored in the future to account for that) 3. Landuse variables I/O 4. Variables in creating restart file 5. Variables at every timestep - Redesign `cable_output` with introducing `generate_out_write_acc`, and `check_and_write` - Change the range checks to be done in `cable_write` during `cable_output`. - Make `output_inclusion_type` dependencies clear between group output and individual values Tested with experiments in `bench_example` for `main` vs current commit.  ---- 📚 Documentation preview 📚: https://cable--287.org.readthedocs.build/en/287/

…e-params

# CABLE ## Description Fixes #225 Add 2 flags to range checks ``` check%ranges (0, 1, 2) - When to do the range checks NO_CHECK, ON_TIMESTEP, ON_WRITE check%exit (.true., .false.) - Whether to exit the program if range checks are done, and out of range - the other option is to provide a warning ``` - Checks are being done in the following stages 1. Parameters of `soil` and `veg` before running the spinloop 2. Parameters when creating the NetCDF output file (some of them clash with `soil` and `veg` but code can be refactored in the future to account for that) 3. Landuse variables I/O 4. Variables in creating restart file 5. Variables at every timestep - Redesign `cable_output` with introducing `generate_out_write_acc`, and `check_and_write` - Change the range checks to be done in `cable_write` during `cable_output`. - Make `output_inclusion_type` dependencies clear between group output and individual values Tested with experiments in `bench_example` for `main` vs current commit.  ---- 📚 Documentation preview 📚: https://cable--287.org.readthedocs.build/en/287/

Co-authored-by: Claire Carouge <[email protected]>

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Guidelines for the review of new contributions. Fixes #186 ## Type of change Please delete options that are not relevant. - [X] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--289.org.readthedocs.build/en/289/

Fixes #163 initialization to 1 so is applicable even IF not over-written by specific case applications. i.e. Will be correct for ESM1.5 # CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Please include a brief summary of the change and list the issues that are fixed. Please also include relevant motivation and context. You can link issues by using a supported keyword in the pull request's description or in a commit message: Fixes #(issue) ## Type of change Please delete options that are not relevant. - [x] Bug fix - [ ] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--274.org.readthedocs.build/en/274/

@rkutteh

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description addendum to #163/#274 You can link issues by using a supported keyword in the pull request's description or in a commit message: Fixes #339 ## Type of change bug fix - [X ] Bug fix - [ ] New or updated documentation ## Checklist - [X] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [X] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. tag @rkutteh  ---- 📚 Documentation preview 📚: https://cable--340.org.readthedocs.build/en/340/

…corrected epot var in cable_canopy. Fixes #335

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Fixes #344. Update the namelist provided with the code for the changes to check%range and other fixes for compatibility with GNU compiler. ## Type of change Please delete options that are not relevant. - [X] Bug fix ## Checklist I have compiled the code and run the Tumbarumba test case with the updated namelist. The test case finished: ``` Finished. 36.78621 seconds needed for year Finished. 36.78769 seconds needed for 70128 hours ``` Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--345.org.readthedocs.build/en/345/

…ffline output. fixes #346

…on-directly-from-the-offline-code-base

Co-authored-by: Claire Carouge <[email protected]>

Set density_ice = 917 kg/m3 in cable_phys_constants_mod.F90 and soilin%rhosoil to 917 kg/m3 for 'Permanent ice' in cable_soilparm.nml, in connection to #326  ---- 📚 Documentation preview 📚: https://cable--332.org.readthedocs.build/en/332/

…IR; fixes #355

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Fixes #359 Changes for checking ranges have changed how the `output%X` logical switches are set. This was not reflected in the MPI driver which meant no outputs were produced from simulations using MPI. Fix include: - Add call to `set_group_output_values` in cable_mpimaster.F90. - Add call to `constant_check_range()` in cable_mpiworker.F90. This check was added during the work to check ranges in the serial version. This has no impact on the CABLE outputs but allows the MPI and serial versions to contain the same functionality. - Changed the logic for `logn` and `wlogn` settings. `wlogn` variable is removed since all cores can use `logn` to capture their log file unit number. This allows the logs from the check ranges to appear correctly in the logs. ## Type of change Please delete options that are not relevant. - [X] Bug fix ## Testing Fluxsite tests with benchcab ran as expected showing no differences with the main branch. Ran spatial tests with benchcab for this branch and the main branch. The netcdf files for this branch now contain outputs for all requested variables. ### Output file header for main: ``` netcdf cable_out { dimensions: x = 192 ; y = 112 ; patch = 7 ; soil = 6 ; rad = 3 ; soil_carbon_pools = 2 ; plant_carbon_pools = 3 ; time = UNLIMITED ; // (12 currently) z = 1 ; variables: double time(time) ; time:units = "seconds since 1901-01-01 00:00:00" ; time:coordinate = "GMT" ; time:calendar = "standard" ; float latitude(y, x) ; latitude:units = "degrees_north" ; float longitude(y, x) ; longitude:units = "degrees_east" ; float x(x) ; x:units = "degrees_east" ; x:comment = "x coordinate variable for GrADS compatibility" ; float y(y) ; y:units = "degrees_north" ; y:comment = "y coordinate variable for GrADS compatibility" ; float Area(time, y, x) ; Area:units = "km2" ; Area:long_name = "Patch Area" ; Area:_FillValue = -1.e+33f ; Area:missing_value = -1.e+33f ; // global attributes: :Production = "2024/08/05 at 12:35:48" ; :Source = "CABLE LSM output file" ; :CABLE_input_file = "" ; :Output_averaging = "monthly" ; } ``` ### Output file header for this branch: ``` netcdf cable_out { dimensions: x = 192 ; y = 112 ; patch = 7 ; soil = 6 ; rad = 3 ; soil_carbon_pools = 2 ; plant_carbon_pools = 3 ; time = UNLIMITED ; // (12 currently) z = 1 ; variables: double time(time) ; time:units = "seconds since 1901-01-01 00:00:00" ; time:coordinate = "GMT" ; time:calendar = "standard" ; float latitude(y, x) ; latitude:units = "degrees_north" ; float longitude(y, x) ; longitude:units = "degrees_east" ; float x(x) ; x:units = "degrees_east" ; x:comment = "x coordinate variable for GrADS compatibility" ; float y(y) ; y:units = "degrees_north" ; y:comment = "y coordinate variable for GrADS compatibility" ; float SWdown(time, y, x) ; SWdown:units = "W/m^2" ; SWdown:long_name = "Downward shortwave radiation" ; SWdown:_FillValue = -1.e+33f ; SWdown:missing_value = -1.e+33f ; ... ``` Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--360.org.readthedocs.build/en/360/

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description A single line bug fix to address cases where the diagnosed screen level temperature does not deviate from the reference level air temperature. This only impacts some sites with tall vegetation. Note that this change addresses the immediate issue - other aspects involving code structure and when in the calling sequence the screen level diagnostics should occur have been left untouched. This is intended as a bug fix impacting only the screen level temperature and humidity - all other variables should remain as before. However this change is - by design -not bitwise comparable with the MAIN so may fail Benchcab testing. Fixes #313 ## Type of change Please delete options that are not relevant. - [x] Bug fix ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings ## Testing results benchcab/me.org results: https://modelevaluation.org/analyses/anywhere/32ykm3nn4EfJCro8q/s6k22L3WajmiS9uGv/fHu3wwScyjcNpjApy/all (added after approval as the analyses needed some debugging)  ---- 📚 Documentation preview 📚: https://cable--316.org.readthedocs.build/en/316/

#346) # CABLE Thank you for submitting a pull request to the CABLE Project. ## Description This PR adds the potential evaporation diagnostic (`canopy%epot`) to fluxes section of the cable output. A minor correction to the diagnostic has also been applied - which could lead to impacts in the coupled model (via `%wetfac_cs` and JULES variable `resft`) - and the checks_ranges updated. Fixes #335 ## Type of change Please delete options that are not relevant. - [x] Bug fix - [x] additional output ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--346.org.readthedocs.build/en/346/

# CABLE ## Description This PR aims to achieve two tasks - removing the hard-wired lake index from the offline code (including GW module) - maintaining lakes at saturation in offline model (soil-snow only) Fixes #341 Addresses #347 ## Type of change - [x] Bug fix - [x] Science advancement ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--348.org.readthedocs.build/en/348/

changed write statements inside consistency_ice_veg_soil subroutine to output to logn instead of standard output

…-user-guide

# CABLE ## Description Added a table of physical constants and a table of mathematical constants to the user guide. Additional tables of constants can be added following the same pattern. Fixed missing/incorrect units in code and documentation. **It might be a good time at this stage to decide on the numerical value to use for the ice density: 910 from cable_soilparm.nml OR 921 from cable_phys_constants_mod.F90 ?** Interestingly another well known code uses 917. - [X] New or updated documentation  ---- 📚 Documentation preview 📚: https://cable--326.org.readthedocs.build/en/326/

Remove double summation of btran (#279) Require both changes.

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Fixes #351. Move the definition of sum_rad_gradis and sum_rad_rniso out of the NITER loop in `define_canopy()` since these variables do not change in the loop. Having a quick comparison between the outputs before and after this commit [the effect is negligeable](#352 (comment)). Use `sum_rad_gradis` and `sum_rad_rniso` as calculated in define_canopy() everywhere in define_canopy(), dryLeaf() and wetLeaf(), instead of recalculating them sometimes. Move the initialisation of `canopy%DvLitt` and `canopy%kthLitt` to the top of `define_canopy()` since these variables are constant throughout the run. We also want these variables to be defined in all cases to avoid errors in function calls, but only used with `cable_user%litter` turned on. ## Type of change Please delete options that are not relevant. - [X] Bug fix ## Testing benchcab/me.org analysis: https://modelevaluation.org/analyses/anywhere/BPLvifw3DyARokYdg/s6k22L3WajmiS9uGv/CJGXP5GQWhGf3nH28/all Tested in benchcab the changes for DvLitt and kthLitt on their own. benchcab showed bitwise identical results when moving the initialisation compared to the previous implementation with the litter option on. Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--352.org.readthedocs.build/en/352/

# CABLE Add a subroutine to CABLE to ensure the consistency of ice points between soil and vegetation, related to #338. This branch will be used for the benchcab testing. Fixes #280 Fixes #338  ---- 📚 Documentation preview 📚: https://cable--349.org.readthedocs.build/en/349/

…ersion

# CABLE ## Description Following analysis in CABLE4 and discussion in #354 we should use total SW down in the call to `spitter` and apply the resultant `Fbeam` equally to the visible and near-infrared bands. The original intent (cable1.4) of spitter is to evaluate the fraction of SW down that is diffuse in nature - via the beam fraction `Fbeam`. This was evaluated once based on the total shortwave down. From CABLE2 onwards spitter was called twice - once for the visible and once for the near-infrared components. However the function itself was not adjusted - the result is that beam fraction is universally smaller than the original intent with unknown impacts on the model trajectory. This change set reverts the evaluation of `Fbeam` to operate on the total SW down and then applies `Fbeam` equally to the two radiation bands. This has been implemented as a bug fix, not on a switch. This change may require recalibration of the CABLE model (notably stomatal conductance parameters, leaf nitrogen exponential and any other parameters that impact GPP). Fixes #355 ## Type of change - [x] Bug fix - [ ] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings  ---- 📚 Documentation preview 📚: https://cable--357.org.readthedocs.build/en/357/

# CABLE ground water hydrology work of Mengyuan Mu This pull request is part of integrating the ground water hydrology work of Mengyuan Mu into CABLE, which will take place in a sequence of pull requests. The actual integration project itself was completed back in September 2023. The current work involves just a gradual merge into the main branch. Fixes #230 ## Description 1. cable_gw_hydro.F90 is replaced by its new version (drop-in replacement) 2. Dependencies are introduced in **src/offline/cable_parameters.F90**, **src/offline/cable_define_types.F90**, **src/science/soilsnow/cbl_thermal.F90**, and **src/util/cable_common.F90** in order for the code to compile successfully (confirmed) 3. *PLEASE* do not delete any of my in-code comments (tagged rk4417) for now. Once the integration of the ground water hydrology work is complete and its functionality is confirmed to reproduce the results obtained already outside of the repo, I will clean-up all of my comments in a single pull request. Deleting any of my comments now will just make it much more difficult for me to track down and fix any issues that might arise during this process.  ---- 📚 Documentation preview 📚: https://cable--231.org.readthedocs.build/en/231/

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description The creation of the call graphs (and others) by FORD in the API documentation was broken since moving to readthedocs. This should solve the issue Fixes #9 ## Type of change Please delete options that are not relevant. - [X] Bug fix ## Testing We do not build the graphs in the pull request preview of the documentation since it takes >3 min to build the doc with the graphs. This was tested in this fork: https://github.com/ccarouge/CABLE_test Result example in the documentation: https://cable-test.readthedocs.io/en/latest/api/proc/bgcdriver.html Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--399.org.readthedocs.build/en/399/

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description casaflux%frac_sapwood needs to be initialised to 1 for the correct calculation of casaflux%crmplant(:,wood) in casa_rplant when cable_user%CALL_climate is not true. This had been done in casa_inout at #274 but this subroutine is only used for offline simulations. This change does the initialisation, in casa_init_pk, for ESM1.5/ESM1.6 cases. Fixes #373 ## Type of change Please delete options that are not relevant. - [X ] Bug fix ## Checklist - [ ] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--374.org.readthedocs.build/en/374/

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description As described in #275, this change reinstates code that had been removed in 2022 with little justification. Reinstating the code provides consistency with ACCESS-ESM1.5 and also with relevant code in src_pop/core/biogeochem. Testing for a small sample of sites showed a large impact if this change was made alone. The related issue (#279) incorrectly calculates btran by summing over layers twice. This calculation is only used if the removed code in #275 is reinstated. Site tests with both changes showed only small differences. Change only impacts runs with CASA-CNP active. Also dealt with corrections to comment for subroutine avgsoil as noted in #279 and subroutine casa_coeffsoil (#277). Fixes #275, #277, #279. ## Type of change Please delete options that are not relevant. - [X ] Bug fix - [ ] New or updated documentation ## Checklist - [ ] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--372.org.readthedocs.build/en/372/

AM3 application specific see issue #370 Fixes #370 ## Type of change Hopefully will cover CM3 as well - [? ] New or updated documentation ## Checklist - [? ] The new content is accessible and located in the appropriate section. - [?] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings  ---- 📚 Documentation preview 📚: https://cable--371.org.readthedocs.build/en/371/

The build-ci action has now been fixed (see ACCESS-NRI/build-ci#179). Fixes #408  ---- 📚 Documentation preview 📚: https://cable--409.org.readthedocs.build/en/409/

…odule, as gfortran provides a similar function that takes no arguments.

…g unused variables and arguments.

#375) # CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Removed two ifdef ESM15 cases related to the use of xkpsorb. The ESM15 code option is inconsistent with how xkpsorb is input in the CABLE3 code. Fixes #283 ## Type of change - [X ] Bug fix ## Checklist - [ ] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--375.org.readthedocs.build/en/375/

…LE2.4/ACCESS-ESM1.5

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description This PR fixes compilation with gfortran. I also fixes several compiler warnings (mostly about unused variables) in the MPI master/driver modules. ## Type of change Please delete options that are not relevant. - [X] Bug fix ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings  ---- 📚 Documentation preview 📚: https://cable--410.org.readthedocs.build/en/410/

# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description In casa_delsoil the evaluation of casaflux%Pleach had two versions, one specific to ESM1.5 (selected via an ifdef) and the alternat for all other cases. Following the code through, the ESM1.5 version had a hard-wired value (1.e-4) for casaflux%fPleach. casaflux%fPleach is filled from xfPleach which is read in from the pftlookup file. The ESM1.5 specific code can be safely removed with no change to the output if xfPleach is set to 1.e-4 in the pftlookup file. Note that there are versions of the pftlookup with xfPleach = 5.e-4. I am not aware of when/who set it to this value and whether it is considered to be better/more realistic. Fixes #278 ## Type of change Please delete options that are not relevant. - [X] Code clean-up ## Checklist - [X ] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [X ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review.  ---- 📚 Documentation preview 📚: https://cable--422.org.readthedocs.build/en/422/

Commits on Nov 28, 2023

write review guidelines - Fixes #186

ccarouge committed Nov 28, 2023

Configuration menu

View commit details

Copy full SHA for ff709c7

Browse repository at this point

Copy the full SHA

ff709c7 View commit details

Browse the repository at this point in the history

Commits on Mar 17, 2024

Introduce SUBROUTINE GWspatialParameters

rkutteh committed Mar 17, 2024

Configuration menu

View commit details

Copy full SHA for ba007d5

Browse repository at this point

Copy the full SHA

ba007d5 View commit details

Browse the repository at this point in the history

Commits on May 9, 2024

(#186 ): additions to review guidelines

C. Carouge committed May 9, 2024

Configuration menu

View commit details

Copy full SHA for 87c9592

Browse repository at this point

Copy the full SHA

87c9592 View commit details

Browse the repository at this point in the history

Commits on May 15, 2024

(#186 ): few more edits

ccarouge committed May 15, 2024

Configuration menu

View commit details

Copy full SHA for 8d73f90

Browse repository at this point

Copy the full SHA

8d73f90 View commit details

Browse the repository at this point in the history

Commits on May 16, 2024

(#186 ): simplify language (review)

C. Carouge committed May 16, 2024

Configuration menu

View commit details

Copy full SHA for d8b5538

Browse repository at this point

Copy the full SHA

d8b5538 View commit details

Browse the repository at this point in the history

Commits on May 22, 2024

Auto refresh MathJax on page load

abhaasgoyal committed May 22, 2024

Configuration menu

View commit details

Copy full SHA for 400f550

Browse repository at this point

Copy the full SHA

400f550 View commit details

Browse the repository at this point in the history

Commits on Aug 5, 2024

(#359 ) - Set logn for workers

C. Carouge committed Aug 5, 2024

Configuration menu

View commit details

Copy full SHA for 93b16a1

Browse repository at this point

Copy the full SHA

93b16a1 View commit details

Browse the repository at this point in the history

Updating 219 from main. #426

Updating 219 from main. #426

Commits on Nov 28, 2023

Commits on Mar 12, 2024

Commits on Mar 14, 2024

Commits on Mar 15, 2024

Commits on Mar 17, 2024

Commits on Mar 19, 2024

Commits on Apr 6, 2024

Commits on Apr 7, 2024

Commits on Apr 10, 2024

Commits on Apr 19, 2024

Commits on May 7, 2024

Commits on May 9, 2024

Commits on May 10, 2024

Commits on May 15, 2024

Commits on May 16, 2024

Commits on May 20, 2024

Commits on May 22, 2024

Commits on May 24, 2024

Commits on May 30, 2024

Commits on Jun 2, 2024

Commits on Jun 3, 2024

Commits on Jun 6, 2024

Commits on Jun 7, 2024

Commits on Jun 17, 2024

Commits on Jun 18, 2024

Commits on Jun 21, 2024

Commits on Jun 27, 2024

Commits on Jul 2, 2024

Commits on Jul 3, 2024

Commits on Jul 11, 2024

Commits on Jul 12, 2024

Commits on Jul 15, 2024

Commits on Jul 16, 2024

Commits on Jul 17, 2024

Commits on Jul 18, 2024

Commits on Jul 25, 2024

Commits on Jul 26, 2024

Commits on Jul 30, 2024

Commits on Aug 2, 2024

Commits on Aug 5, 2024

Commits on Aug 6, 2024

Commits on Aug 7, 2024

Commits on Aug 8, 2024

Commits on Aug 9, 2024

Commits on Aug 13, 2024

Commits on Aug 15, 2024

Commits on Aug 19, 2024

Commits on Aug 21, 2024

Commits on Aug 23, 2024

Commits on Aug 26, 2024

Commits on Aug 29, 2024

Commits on Sep 1, 2024

Commits on Sep 12, 2024

Commits on Sep 15, 2024

Commits on Sep 17, 2024

Commits on Sep 30, 2024

Commits on Oct 8, 2024

Commits on Oct 14, 2024

Commits on Oct 17, 2024

Commits on Oct 18, 2024