-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating 219 from main. #426
Updating 219 from main. #426
Commits on Nov 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ff709c7 - Browse repository at this point
Copy the full SHA ff709c7View commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8ff8a98 - Browse repository at this point
Copy the full SHA 8ff8a98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77fa660 - Browse repository at this point
Copy the full SHA 77fa660View commit details -
Configuration menu - View commit details
-
Copy full SHA for 563906f - Browse repository at this point
Copy the full SHA 563906fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec74353 - Browse repository at this point
Copy the full SHA ec74353View commit details -
Configuration menu - View commit details
-
Copy full SHA for a30cbd3 - Browse repository at this point
Copy the full SHA a30cbd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b8d0e3 - Browse repository at this point
Copy the full SHA 7b8d0e3View commit details
Commits on Mar 14, 2024
-
Use find_package to link against MPI libraries
This is done so that: 1. We can create separate targets for the serial and MPI executable and only link against the MPI libraries when needed without relying on the MPI compiler wrapper. This lets us compile all executables (serial and parallel) with a single invocation of CMake. 2. We can use object libraries to compile the object files common to both serial and MPI builds. This saves compiling these object files for each executable (serial and MPI), reducing compilation time. Note: since compiler flags are the same across all targets, this change applies the flags globally to all targets in the current directory and below via [`add_compile_options`][add_compile_options]. [add_compile_options]: https://cmake.org/cmake/help/latest/command/add_compile_options.html
Configuration menu - View commit details
-
Copy full SHA for b174460 - Browse repository at this point
Copy the full SHA b174460View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0ce0e4 - Browse repository at this point
Copy the full SHA c0ce0e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0369c4e - Browse repository at this point
Copy the full SHA 0369c4eView commit details -
Add --compiler flag and GNU compiler support
Flags for release and debug configurations for the GNU compiler were taken from build.ksh (CABLE-POP_TRENDY branch).
Configuration menu - View commit details
-
Copy full SHA for 93ac165 - Browse repository at this point
Copy the full SHA 93ac165View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29d8b26 - Browse repository at this point
Copy the full SHA 29d8b26View commit details
Commits on Mar 15, 2024
-
Additional CMake changes (#216)
This pull request should follow after the CMake implementation (see #200). This change adds the following build system changes: - List source files in alphabetical order in CMakeLists.txt. The order of source files was previously chosen so that we could demonstrate binary equivalence in executables between the CMake build and the Makefile build. - Use [`find_package(MPI REQUIRED)`](https://cmake.org/cmake/help/latest/module/FindMPI.html) instead of specifying `mpif90` when invoking `cmake` for MPI case. This is done so that 1. We can create separate targets for the serial and MPI executable and only link against the MPI libraries when needed without relying on the MPI compiler wrapper. This lets us compile all executables (serial and parallel) with a single invocation of CMake. 2. We can use object libraries to compile the object files common to both serial and MPI builds. This saves compiling these object files for each executable (serial and MPI), reducing compilation time. - Portability fixes and improvements to build.bash. - Add `--compiler` flag to build.bash and GNU compiler support. - Add Matthias's configuration for example. Regression tests using [benchcab](https://github.com/CABLE-LSM/benchcab)* (bitwise comparison of model output via nccmp) show that model output is bitwise identical between the current branch and the main branch for serial and MPI model runs. *executables were built manually as benchcab does not yet support the recent build system changes (see related issue: CABLE-LSM/benchcab#258). Fixes #215 <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--216.org.readthedocs.build/en/216/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for dabb1c9 - Browse repository at this point
Copy the full SHA dabb1c9View commit details
Commits on Mar 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ba007d5 - Browse repository at this point
Copy the full SHA ba007d5View commit details
Commits on Mar 19, 2024
-
Add model build CI for CABLE offline (#223)
Making CABLE available as a [spack](https://spack.io/) package allows us to test the model compiles successfully inside a continuous integration (CI) environment which gets triggered automatically on a pull request. This change adds the model build CI workflow developed by the ACCESS-NRI release team to compile CABLE offline via spack (see [build-ci](https://github.com/ACCESS-NRI/build-ci) for more details). This workflow compiles CABLE using the intel compiler. The CI for other compilers will follow after this pull request. Fixes #202 <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--223.org.readthedocs.build/en/223/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 281a621 - Browse repository at this point
Copy the full SHA 281a621View commit details
Commits on Apr 6, 2024
-
Introduce SUBROUTINE GWspatialParameters (#224)
# CABLE ground water hydrology work of Mengyuan Mu This pull request is part of integrating the ground water hydrology work of Mengyuan Mu into CABLE, which will take place in a sequence of pull requests. The actual integration project itself was completed back in September 2023. The current work involves just a gradual merge into the main branch. ## Description 1. A new SUBROUTINE GWspatialParameters is introduced in **src/offline/cable_parameters.F90** 2. This subroutine will eventually be called only once, from **src/offline/cable_input.F90**. I will add this call at the appropriate time, but for now the subroutine is inactive 3. Dependencies are introduced in **src/offline/cable_parameters.F90** and **src/offline/cable_define_types.F90** in order for the code to compile successfully (confirmed) 4. This pull request involves only code additions, no deletions or modifications of existing code were carried out (some minor typos I came across in existing comments were fixed) 5. *PLEASE* do not delete any of my in-code comments (tagged rk4417) for now. Once the integration of the ground water hydrology work is complete and its functionality is confirmed to reproduce the results obtained already outside of the repo, I will clean-up all of my comments in a single pull request. Deleting any of my comments now will just make it much more difficult for me to track down and fix any issues that might arise during this process. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--224.org.readthedocs.build/en/224/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for fed2a4c - Browse repository at this point
Copy the full SHA fed2a4cView commit details
Commits on Apr 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fba0e4a - Browse repository at this point
Copy the full SHA fba0e4aView commit details
Commits on Apr 10, 2024
-
# CABLE ## Description gfortran could not compile the CABLE main branch, neither in release mode (-O3 -Wno-aggressive-loop-optimizations) nor in debug mode (-O -g -pedantic-errors -Wall -W -Wno-maybe-uninitialized -fbacktrace -ffpe-trap=zero,overflow,underflow -finit-real=nan). The name `mland` was an ambiguous reference in the routine `landuse_allocate_mland` in landuse3.F90 because it is used via landuse_constant and defined in `landuse_allocate_mland`. I renamed it locally to `imland` in the routine. With this change, the release mode compiled. However there were plenty of 'Nonconforming tab character' and 'continued character constant' in the other files. I removed all that and now it compiles in release and debug mode. ## Type of change Please delete options that are not relevant. - [x] Bug fix - [ ] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--221.org.readthedocs.build/en/221/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 46830b3 - Browse repository at this point
Copy the full SHA 46830b3View commit details
Commits on Apr 19, 2024
-
Add support for MPI builds with the GNU compiler (#241)
The build script currently does not support MPI builds with the GNU compiler on Gadi. This is due to the `intel-mpi` module being loaded when we should be using an MPI module that is compatible with the chosen compiler. This change loads the `openmpi` module when GNU compilation is enabled in the build script. Fixes #239 <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--241.org.readthedocs.build/en/241/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for a6e0dcc - Browse repository at this point
Copy the full SHA a6e0dccView commit details
Commits on May 7, 2024
-
(#285): run testcase from within src/offline/ for now.
C. Carouge committedMay 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 81b8795 - Browse repository at this point
Copy the full SHA 81b8795View commit details -
Fix testcase from Uber Quick guide. (#286)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Fixes #(285) Change Uber Quick guide instructions to run the testcase from src/offline/ since for now CABLE needs the namelists in the run directory. ## Type of change Please delete options that are not relevant. - [X] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--286.org.readthedocs.build/en/286/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 45d1497 - Browse repository at this point
Copy the full SHA 45d1497View commit details
Commits on May 9, 2024
-
(#186): additions to review guidelines
C. Carouge committedMay 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 87c9592 - Browse repository at this point
Copy the full SHA 87c9592View commit details
Commits on May 10, 2024
-
C. Carouge committed
May 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 3ab8f45 - Browse repository at this point
Copy the full SHA 3ab8f45View commit details -
C. Carouge committed
May 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 5d7b808 - Browse repository at this point
Copy the full SHA 5d7b808View commit details
Commits on May 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8d73f90 - Browse repository at this point
Copy the full SHA 8d73f90View commit details
Commits on May 16, 2024
-
(#186): simplify language (review)
C. Carouge committedMay 16, 2024 Configuration menu - View commit details
-
Copy full SHA for d8b5538 - Browse repository at this point
Copy the full SHA d8b5538View commit details
Commits on May 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 38e2a64 - Browse repository at this point
Copy the full SHA 38e2a64View commit details
Commits on May 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 400f550 - Browse repository at this point
Copy the full SHA 400f550View commit details
Commits on May 24, 2024
-
Case of mobile is not a major consideration here, comfort on a computer is more important
Configuration menu - View commit details
-
Copy full SHA for 21195f6 - Browse repository at this point
Copy the full SHA 21195f6View commit details -
(#303): reducing left and right margins (#305)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Increase the overall width of the page. This removes the large left and right margins and tend to improve the rendering of the tables throughout the documentation. You can link issues by using a supported keyword in the pull request's description or in a commit message: Fixes #(303) ## Type of change Please delete options that are not relevant. - [X] New or updated documentation ## Checklist - [X] The new content is accessible and located in the appropriate section. - [X] I have checked that links are valid and point to the intended content. - [X] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--305.org.readthedocs.build/en/305/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 4d28958 - Browse repository at this point
Copy the full SHA 4d28958View commit details -
Auto refresh MathJax on page load (#304)
# CABLE Resolves #298 Recently, the [documentation](https://squidfunk.github.io/mkdocs-material/reference/math/#mathjax) for MathJax changed to reset the typeset after instant page load. Considering that it's a cache issue, we would know for sure that the effect after it's on the main `readthedocs` is built again. Seems to work well for readthedocs PR preview (although they do hard refresh for every new page load) Relevant issues - squidfunk/mkdocs-material#6661 - squidfunk/mkdocs-material#6407 <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--304.org.readthedocs.build/en/304/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 0c4139f - Browse repository at this point
Copy the full SHA 0c4139fView commit details
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 63bd149 - Browse repository at this point
Copy the full SHA 63bd149View commit details
Commits on Jun 2, 2024
-
Update documentation/docs/user_guide/inputs/pft_params_nml.md
Co-authored-by: Claire Carouge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d5acf42 - Browse repository at this point
Copy the full SHA d5acf42View commit details
Commits on Jun 3, 2024
-
Update content of pft_params.nml options under User Guide (#299)
## Description Updated content of pft_params.nml options under User Guide as a side task of another GW-related task. Added text and tables to provide more and neater content. ## Type of change - [ ] New or updated documentation <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--299.org.readthedocs.build/en/299/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for c2c0316 - Browse repository at this point
Copy the full SHA c2c0316View commit details
Commits on Jun 6, 2024
-
Update src/offline/cable_input.F90
Comment alignment Co-authored-by: Claire Carouge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cad3cc9 - Browse repository at this point
Copy the full SHA cad3cc9View commit details -
Defined ncid_mask for met data files with multiple sites. Fixes #306. (…
…#308) # CABLE Thank you for submitting a pull request to the CABLE Project. ## Description The model crashed when trying to run multiple sites in the met data file. This was because ncid_mask was not defined. Fixes #306 ## Type of change Please delete options that are not relevant. - [X ] Bug fix ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--308.org.readthedocs.build/en/308/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 69331b6 - Browse repository at this point
Copy the full SHA 69331b6View commit details
Commits on Jun 7, 2024
-
Update build-ci version (#271)
Issues in the [build-ci](https://github.com/ACCESS-NRI/build-ci) pipeline have now been fixed. This change updates the build-ci version to incorporate these changes. Fixes #236 <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--271.org.readthedocs.build/en/271/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 43e6bcc - Browse repository at this point
Copy the full SHA 43e6bccView commit details
Commits on Jun 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b70539d - Browse repository at this point
Copy the full SHA b70539dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e33ed3e - Browse repository at this point
Copy the full SHA e33ed3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4ace30 - Browse repository at this point
Copy the full SHA b4ace30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39ae045 - Browse repository at this point
Copy the full SHA 39ae045View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42fb971 - Browse repository at this point
Copy the full SHA 42fb971View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a1442e - Browse repository at this point
Copy the full SHA 3a1442eView commit details -
build.bash improvements (#297)
This PR addresses feedback specific to build.bash raised in PR: #238 Fixes #296 <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--297.org.readthedocs.build/en/297/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for b17cbc0 - Browse repository at this point
Copy the full SHA b17cbc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16dbbe3 - Browse repository at this point
Copy the full SHA 16dbbe3View commit details
Commits on Jun 18, 2024
-
Update documentation/docs/user_guide/inputs/index.md
Co-authored-by: Claire Carouge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 29fe6cd - Browse repository at this point
Copy the full SHA 29fe6cdView commit details -
Update documentation/docs/user_guide/inputs/index.md
Co-authored-by: Claire Carouge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b22a3e7 - Browse repository at this point
Copy the full SHA b22a3e7View commit details -
Add an "Input files" file to the User Guide (#315)
# CABLE ## Description Added more structure and documentation to the user guide, together with a few placeholders to be filled soon. - [X ] New or updated documentation <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--315.org.readthedocs.build/en/315/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 70176c0 - Browse repository at this point
Copy the full SHA 70176c0View commit details
Commits on Jun 21, 2024
-
one line bug fix to address screen level temperatures #313
Ian Harman committedJun 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 2428535 - Browse repository at this point
Copy the full SHA 2428535View commit details
Commits on Jun 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1872ea5 - Browse repository at this point
Copy the full SHA 1872ea5View commit details
Commits on Jul 2, 2024
-
Flags for range checks in CABLE vars (#225)
Fixes #225 Add 2 flags to range checks ``` check%ranges (0, 1, 2) - When to do the range checks NO_CHECK, ON_TIMESTEP, ON_WRITE check%exit (.true., .false.) - Whether to exit the program if range checks are done, and out of range - the other option is to provide a warning ``` - Checks are being done in the following stages 1. Parameters of `soil` and `veg` before running the spinloop 2. Parameters when creating the NetCDF output file (some of them clash with `soil` and `veg` but code can be refactored in the future to account for that) 3. Landuse variables I/O 4. Variables in creating restart file 5. Variables at every timestep - Redesign `cable_output` with introducing `generate_out_write_acc`, and `check_and_write` - Change the range checks to be done in `cable_write` during `cable_output`. - Make `output_inclusion_type` dependencies clear between group output and individual values Tested with experiments in `bench_example` for `main` vs current commit. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--287.org.readthedocs.build/en/287/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for e273737 - Browse repository at this point
Copy the full SHA e273737View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3084239 - Browse repository at this point
Copy the full SHA 3084239View commit details -
Range checks cable parameters (#287)
# CABLE ## Description Fixes #225 Add 2 flags to range checks ``` check%ranges (0, 1, 2) - When to do the range checks NO_CHECK, ON_TIMESTEP, ON_WRITE check%exit (.true., .false.) - Whether to exit the program if range checks are done, and out of range - the other option is to provide a warning ``` - Checks are being done in the following stages 1. Parameters of `soil` and `veg` before running the spinloop 2. Parameters when creating the NetCDF output file (some of them clash with `soil` and `veg` but code can be refactored in the future to account for that) 3. Landuse variables I/O 4. Variables in creating restart file 5. Variables at every timestep - Redesign `cable_output` with introducing `generate_out_write_acc`, and `check_and_write` - Change the range checks to be done in `cable_write` during `cable_output`. - Make `output_inclusion_type` dependencies clear between group output and individual values Tested with experiments in `bench_example` for `main` vs current commit. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--287.org.readthedocs.build/en/287/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for efe332b - Browse repository at this point
Copy the full SHA efe332bView commit details -
Update documentation/docs/user_guide/constants/index.md
Co-authored-by: Claire Carouge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5553fc6 - Browse repository at this point
Copy the full SHA 5553fc6View commit details
Commits on Jul 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a2e177b - Browse repository at this point
Copy the full SHA a2e177bView commit details -
Review process for new contributions (#289)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Guidelines for the review of new contributions. Fixes #186 ## Type of change Please delete options that are not relevant. - [X] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--289.org.readthedocs.build/en/289/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 86b086e - Browse repository at this point
Copy the full SHA 86b086eView commit details
Commits on Jul 11, 2024
-
Reconcile versions of rplant (#274)
Fixes #163 initialization to 1 so is applicable even IF not over-written by specific case applications. i.e. Will be correct for ESM1.5 # CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Please include a brief summary of the change and list the issues that are fixed. Please also include relevant motivation and context. You can link issues by using a supported keyword in the pull request's description or in a commit message: Fixes #(issue) ## Type of change Please delete options that are not relevant. - [x] Bug fix - [ ] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--274.org.readthedocs.build/en/274/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 7b7dcc3 - Browse repository at this point
Copy the full SHA 7b7dcc3View commit details
Commits on Jul 12, 2024
-
bug fix rm USE rplant1 and CALL rplant1 (#340)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description addendum to #163/#274 You can link issues by using a supported keyword in the pull request's description or in a commit message: Fixes #339 ## Type of change bug fix - [X ] Bug fix - [ ] New or updated documentation ## Checklist - [X] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [X] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. tag @rkutteh <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--340.org.readthedocs.build/en/340/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for e521096 - Browse repository at this point
Copy the full SHA e521096View commit details
Commits on Jul 15, 2024
-
(#344) - update value for checks%range
C. Carouge committedJul 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 44ce20e - Browse repository at this point
Copy the full SHA 44ce20eView commit details -
added potential evaporation to offline output, changed checks range, …
…corrected epot var in cable_canopy. Fixes #335
Ian Harman committedJul 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 860094b - Browse repository at this point
Copy the full SHA 860094bView commit details -
(#344) - Changes for compatibility with GNU compiler
C. Carouge committedJul 15, 2024 Configuration menu - View commit details
-
Copy full SHA for b8e24fe - Browse repository at this point
Copy the full SHA b8e24feView commit details -
(#344) - Use enumerator values for conditions on check%ranges
C. Carouge committedJul 15, 2024 Configuration menu - View commit details
-
Copy full SHA for fa555ba - Browse repository at this point
Copy the full SHA fa555baView commit details
Commits on Jul 16, 2024
-
removes hard-wired lake index from code, part of #335 and #347
Ian Harman committedJul 16, 2024 Configuration menu - View commit details
-
Copy full SHA for 4aaccb5 - Browse repository at this point
Copy the full SHA 4aaccb5View commit details -
(#344) - Remove references to check%ranges as LOGICAL in documentation
C. Carouge committedJul 16, 2024 Configuration menu - View commit details
-
Copy full SHA for 5cc5ba4 - Browse repository at this point
Copy the full SHA 5cc5ba4View commit details -
enforcing lakes at saturation. fixes #335
Ian Harman committedJul 16, 2024 Configuration menu - View commit details
-
Copy full SHA for b326199 - Browse repository at this point
Copy the full SHA b326199View commit details -
Update value for checks%range (#345)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Fixes #344. Update the namelist provided with the code for the changes to check%range and other fixes for compatibility with GNU compiler. ## Type of change Please delete options that are not relevant. - [X] Bug fix ## Checklist I have compiled the code and run the Tumbarumba test case with the updated namelist. The test case finished: ``` Finished. 36.78621 seconds needed for year Finished. 36.78769 seconds needed for 70128 hours ``` Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--345.org.readthedocs.build/en/345/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for c2a54da - Browse repository at this point
Copy the full SHA c2a54daView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7068d4 - Browse repository at this point
Copy the full SHA b7068d4View commit details
Commits on Jul 17, 2024
-
reversion of original %epot for connection to ACCESS; new %epot for o…
…ffline output. fixes #346
Ian Harman committedJul 17, 2024 Configuration menu - View commit details
-
Copy full SHA for 0a69346 - Browse repository at this point
Copy the full SHA 0a69346View commit details
Commits on Jul 18, 2024
-
Merge branch 'main' into 335-facilitate-output-of-potential-evaporati…
…on-directly-from-the-offline-code-base
Configuration menu - View commit details
-
Copy full SHA for e53699f - Browse repository at this point
Copy the full SHA e53699fView commit details
Commits on Jul 25, 2024
-
(#351) - define sum_rad_gradis and sum_rad_rniso before wetLeaf call.
C. Carouge committedJul 25, 2024 Configuration menu - View commit details
-
Copy full SHA for a0d4fe2 - Browse repository at this point
Copy the full SHA a0d4fe2View commit details -
reverting lake fix to use field capacity sfc not saturation ssat
Ian Harman committedJul 25, 2024 Configuration menu - View commit details
-
Copy full SHA for a9db7aa - Browse repository at this point
Copy the full SHA a9db7aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45bec15 - Browse repository at this point
Copy the full SHA 45bec15View commit details -
Update src/science/gw_hydro/cable_gw_hydro.F90
Co-authored-by: Claire Carouge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 315b899 - Browse repository at this point
Copy the full SHA 315b899View commit details -
Update src/science/gw_hydro/cable_gw_hydro.F90
Co-authored-by: Claire Carouge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f430650 - Browse repository at this point
Copy the full SHA f430650View commit details -
Update src/science/gw_hydro/cable_gw_hydro.F90
Co-authored-by: Claire Carouge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1c44581 - Browse repository at this point
Copy the full SHA 1c44581View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fac982 - Browse repository at this point
Copy the full SHA 6fac982View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45251dd - Browse repository at this point
Copy the full SHA 45251ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fdcd11 - Browse repository at this point
Copy the full SHA 7fdcd11View commit details -
(#351) - Consistent use of sum_rad_gradis and sum_rad_rniso
C. Carouge committedJul 25, 2024 Configuration menu - View commit details
-
Copy full SHA for d8857aa - Browse repository at this point
Copy the full SHA d8857aaView commit details -
Update src/offline/cable_parameters.F90
Co-authored-by: Claire Carouge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fb4cc3b - Browse repository at this point
Copy the full SHA fb4cc3bView commit details
Commits on Jul 26, 2024
-
Set ice density to 917 kg/m3 (#332)
Set density_ice = 917 kg/m3 in cable_phys_constants_mod.F90 and soilin%rhosoil to 917 kg/m3 for 'Permanent ice' in cable_soilparm.nml, in connection to #326 <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--332.org.readthedocs.build/en/332/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for b7b5850 - Browse repository at this point
Copy the full SHA b7b5850View commit details
Commits on Jul 30, 2024
-
fix bug in spitter call, use total SW down and apply equally to VIS&N…
…IR; fixes #355
Ian Harman committedJul 30, 2024 Configuration menu - View commit details
-
Copy full SHA for f6a95b2 - Browse repository at this point
Copy the full SHA f6a95b2View commit details
Commits on Aug 2, 2024
-
(#359) - Bug fix: outputs broken in MPI implementation
C. Carouge committedAug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 00c70ec - Browse repository at this point
Copy the full SHA 00c70ecView commit details
Commits on Aug 5, 2024
-
C. Carouge committed
Aug 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 93b16a1 - Browse repository at this point
Copy the full SHA 93b16a1View commit details
Commits on Aug 6, 2024
-
(#359) - Removing wlogn, using logn instead for workers and master
C. Carouge committedAug 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 335aa6f - Browse repository at this point
Copy the full SHA 335aa6fView commit details -
Bug fix: outputs broken in MPI implementation (#360)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Fixes #359 Changes for checking ranges have changed how the `output%X` logical switches are set. This was not reflected in the MPI driver which meant no outputs were produced from simulations using MPI. Fix include: - Add call to `set_group_output_values` in cable_mpimaster.F90. - Add call to `constant_check_range()` in cable_mpiworker.F90. This check was added during the work to check ranges in the serial version. This has no impact on the CABLE outputs but allows the MPI and serial versions to contain the same functionality. - Changed the logic for `logn` and `wlogn` settings. `wlogn` variable is removed since all cores can use `logn` to capture their log file unit number. This allows the logs from the check ranges to appear correctly in the logs. ## Type of change Please delete options that are not relevant. - [X] Bug fix ## Testing Fluxsite tests with benchcab ran as expected showing no differences with the main branch. Ran spatial tests with benchcab for this branch and the main branch. The netcdf files for this branch now contain outputs for all requested variables. ### Output file header for main: ``` netcdf cable_out { dimensions: x = 192 ; y = 112 ; patch = 7 ; soil = 6 ; rad = 3 ; soil_carbon_pools = 2 ; plant_carbon_pools = 3 ; time = UNLIMITED ; // (12 currently) z = 1 ; variables: double time(time) ; time:units = "seconds since 1901-01-01 00:00:00" ; time:coordinate = "GMT" ; time:calendar = "standard" ; float latitude(y, x) ; latitude:units = "degrees_north" ; float longitude(y, x) ; longitude:units = "degrees_east" ; float x(x) ; x:units = "degrees_east" ; x:comment = "x coordinate variable for GrADS compatibility" ; float y(y) ; y:units = "degrees_north" ; y:comment = "y coordinate variable for GrADS compatibility" ; float Area(time, y, x) ; Area:units = "km2" ; Area:long_name = "Patch Area" ; Area:_FillValue = -1.e+33f ; Area:missing_value = -1.e+33f ; // global attributes: :Production = "2024/08/05 at 12:35:48" ; :Source = "CABLE LSM output file" ; :CABLE_input_file = "" ; :Output_averaging = "monthly" ; } ``` ### Output file header for this branch: ``` netcdf cable_out { dimensions: x = 192 ; y = 112 ; patch = 7 ; soil = 6 ; rad = 3 ; soil_carbon_pools = 2 ; plant_carbon_pools = 3 ; time = UNLIMITED ; // (12 currently) z = 1 ; variables: double time(time) ; time:units = "seconds since 1901-01-01 00:00:00" ; time:coordinate = "GMT" ; time:calendar = "standard" ; float latitude(y, x) ; latitude:units = "degrees_north" ; float longitude(y, x) ; longitude:units = "degrees_east" ; float x(x) ; x:units = "degrees_east" ; x:comment = "x coordinate variable for GrADS compatibility" ; float y(y) ; y:units = "degrees_north" ; y:comment = "y coordinate variable for GrADS compatibility" ; float SWdown(time, y, x) ; SWdown:units = "W/m^2" ; SWdown:long_name = "Downward shortwave radiation" ; SWdown:_FillValue = -1.e+33f ; SWdown:missing_value = -1.e+33f ; ... ``` Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--360.org.readthedocs.build/en/360/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for da63a72 - Browse repository at this point
Copy the full SHA da63a72View commit details -
one line bug fix to address screen level temperatures #313 (#316)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description A single line bug fix to address cases where the diagnosed screen level temperature does not deviate from the reference level air temperature. This only impacts some sites with tall vegetation. Note that this change addresses the immediate issue - other aspects involving code structure and when in the calling sequence the screen level diagnostics should occur have been left untouched. This is intended as a bug fix impacting only the screen level temperature and humidity - all other variables should remain as before. However this change is - by design -not bitwise comparable with the MAIN so may fail Benchcab testing. Fixes #313 ## Type of change Please delete options that are not relevant. - [x] Bug fix ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings ## Testing results benchcab/me.org results: https://modelevaluation.org/analyses/anywhere/32ykm3nn4EfJCro8q/s6k22L3WajmiS9uGv/fHu3wwScyjcNpjApy/all (added after approval as the analyses needed some debugging) <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--316.org.readthedocs.build/en/316/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for c47f09d - Browse repository at this point
Copy the full SHA c47f09dView commit details -
added potential evaporation to offline output, changed checks range, … (
#346) # CABLE Thank you for submitting a pull request to the CABLE Project. ## Description This PR adds the potential evaporation diagnostic (`canopy%epot`) to fluxes section of the cable output. A minor correction to the diagnostic has also been applied - which could lead to impacts in the coupled model (via `%wetfac_cs` and JULES variable `resft`) - and the checks_ranges updated. Fixes #335 ## Type of change Please delete options that are not relevant. - [x] Bug fix - [x] additional output ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--346.org.readthedocs.build/en/346/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for e6be17c - Browse repository at this point
Copy the full SHA e6be17cView commit details
Commits on Aug 7, 2024
-
Merge branch 'main' into 338-consistency_ice_veg_soil
C. Carouge committedAug 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 6311935 - Browse repository at this point
Copy the full SHA 6311935View commit details -
fixing broken lake tiles in offline #335 and addresses #347 (#348)
# CABLE ## Description This PR aims to achieve two tasks - removing the hard-wired lake index from the offline code (including GW module) - maintaining lakes at saturation in offline model (soil-snow only) Fixes #341 Addresses #347 ## Type of change - [x] Bug fix - [x] Science advancement ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--348.org.readthedocs.build/en/348/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 32ad6b7 - Browse repository at this point
Copy the full SHA 32ad6b7View commit details -
changed write statements inside consistency_ice_veg_soil subroutine to output to logn instead of standard output
Configuration menu - View commit details
-
Copy full SHA for d395e01 - Browse repository at this point
Copy the full SHA d395e01View commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1239fec - Browse repository at this point
Copy the full SHA 1239fecView commit details
Commits on Aug 9, 2024
-
Add a table of physical constants to the user guide (#326)
# CABLE ## Description Added a table of physical constants and a table of mathematical constants to the user guide. Additional tables of constants can be added following the same pattern. Fixed missing/incorrect units in code and documentation. **It might be a good time at this stage to decide on the numerical value to use for the ice density: 910 from cable_soilparm.nml OR 921 from cable_phys_constants_mod.F90 ?** Interestingly another well known code uses 917. - [X] New or updated documentation <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--326.org.readthedocs.build/en/326/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 8b93b3b - Browse repository at this point
Copy the full SHA 8b93b3bView commit details
Commits on Aug 13, 2024
-
Always initialise canopy%DvLitt and canopy%kthLitt
C. Carouge committedAug 13, 2024 Configuration menu - View commit details
-
Copy full SHA for fe0b80e - Browse repository at this point
Copy the full SHA fe0b80eView commit details
Commits on Aug 15, 2024
-
Reinstate dry and cold stress (#275)
Remove double summation of btran (#279) Require both changes.
Configuration menu - View commit details
-
Copy full SHA for fdcb99f - Browse repository at this point
Copy the full SHA fdcb99fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bd295b - Browse repository at this point
Copy the full SHA 7bd295bView commit details -
(#338) - Add namelist option for ice consistency.
C. Carouge committedAug 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 4db0469 - Browse repository at this point
Copy the full SHA 4db0469View commit details -
C. Carouge committed
Aug 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 6ed2afc - Browse repository at this point
Copy the full SHA 6ed2afcView commit details -
(#351) - correct reference for DvLitt and kthLitt
C. Carouge committedAug 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 06bd3af - Browse repository at this point
Copy the full SHA 06bd3afView commit details -
Fix: uninitialised variables in cable_canopy.F90 (#352)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Fixes #351. Move the definition of sum_rad_gradis and sum_rad_rniso out of the NITER loop in `define_canopy()` since these variables do not change in the loop. Having a quick comparison between the outputs before and after this commit [the effect is negligeable](#352 (comment)). Use `sum_rad_gradis` and `sum_rad_rniso` as calculated in define_canopy() everywhere in define_canopy(), dryLeaf() and wetLeaf(), instead of recalculating them sometimes. Move the initialisation of `canopy%DvLitt` and `canopy%kthLitt` to the top of `define_canopy()` since these variables are constant throughout the run. We also want these variables to be defined in all cases to avoid errors in function calls, but only used with `cable_user%litter` turned on. ## Type of change Please delete options that are not relevant. - [X] Bug fix ## Testing benchcab/me.org analysis: https://modelevaluation.org/analyses/anywhere/BPLvifw3DyARokYdg/s6k22L3WajmiS9uGv/CJGXP5GQWhGf3nH28/all Tested in benchcab the changes for DvLitt and kthLitt on their own. benchcab showed bitwise identical results when moving the initialisation compared to the previous implementation with the litter option on. Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--352.org.readthedocs.build/en/352/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 04e8171 - Browse repository at this point
Copy the full SHA 04e8171View commit details
Commits on Aug 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6f22bdd - Browse repository at this point
Copy the full SHA 6f22bddView commit details
Commits on Aug 21, 2024
-
(#338) - Add new namelist option to cable.nml
C. Carouge committedAug 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 57a343d - Browse repository at this point
Copy the full SHA 57a343dView commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 03f924e - Browse repository at this point
Copy the full SHA 03f924eView commit details
Commits on Aug 26, 2024
-
consistency_ice_veg_soil (#349)
# CABLE Add a subroutine to CABLE to ensure the consistency of ice points between soil and vegetation, related to #338. This branch will be used for the benchcab testing. Fixes #280 Fixes #338 <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--349.org.readthedocs.build/en/349/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 420ca49 - Browse repository at this point
Copy the full SHA 420ca49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dd3724 - Browse repository at this point
Copy the full SHA 1dd3724View commit details
Commits on Aug 29, 2024
-
fix bug in spitter call (MAIN) (#357)
# CABLE ## Description Following analysis in CABLE4 and discussion in #354 we should use total SW down in the call to `spitter` and apply the resultant `Fbeam` equally to the visible and near-infrared bands. The original intent (cable1.4) of spitter is to evaluate the fraction of SW down that is diffuse in nature - via the beam fraction `Fbeam`. This was evaluated once based on the total shortwave down. From CABLE2 onwards spitter was called twice - once for the visible and once for the near-infrared components. However the function itself was not adjusted - the result is that beam fraction is universally smaller than the original intent with unknown impacts on the model trajectory. This change set reverts the evaluation of `Fbeam` to operate on the total SW down and then applies `Fbeam` equally to the two radiation bands. This has been implemented as a bug fix, not on a switch. This change may require recalibration of the CABLE model (notably stomatal conductance parameters, leaf nitrogen exponential and any other parameters that impact GPP). Fixes #355 ## Type of change - [x] Bug fix - [ ] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--357.org.readthedocs.build/en/357/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for d45a62c - Browse repository at this point
Copy the full SHA d45a62cView commit details
Commits on Sep 1, 2024
-
Replace cable_gw_hydro.F90 with its new version (#231)
# CABLE ground water hydrology work of Mengyuan Mu This pull request is part of integrating the ground water hydrology work of Mengyuan Mu into CABLE, which will take place in a sequence of pull requests. The actual integration project itself was completed back in September 2023. The current work involves just a gradual merge into the main branch. Fixes #230 ## Description 1. cable_gw_hydro.F90 is replaced by its new version (drop-in replacement) 2. Dependencies are introduced in **src/offline/cable_parameters.F90**, **src/offline/cable_define_types.F90**, **src/science/soilsnow/cbl_thermal.F90**, and **src/util/cable_common.F90** in order for the code to compile successfully (confirmed) 3. *PLEASE* do not delete any of my in-code comments (tagged rk4417) for now. Once the integration of the ground water hydrology work is complete and its functionality is confirmed to reproduce the results obtained already outside of the repo, I will clean-up all of my comments in a single pull request. Deleting any of my comments now will just make it much more difficult for me to track down and fix any issues that might arise during this process. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--231.org.readthedocs.build/en/231/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 95b9b5e - Browse repository at this point
Copy the full SHA 95b9b5eView commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aad87bc - Browse repository at this point
Copy the full SHA aad87bcView commit details -
Create call graphs in doc (#399)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description The creation of the call graphs (and others) by FORD in the API documentation was broken since moving to readthedocs. This should solve the issue Fixes #9 ## Type of change Please delete options that are not relevant. - [X] Bug fix ## Testing We do not build the graphs in the pull request preview of the documentation since it takes >3 min to build the doc with the graphs. This was tested in this fork: https://github.com/ccarouge/CABLE_test Result example in the documentation: https://cable-test.readthedocs.io/en/latest/api/proc/bgcdriver.html Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--399.org.readthedocs.build/en/399/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 11d8197 - Browse repository at this point
Copy the full SHA 11d8197View commit details
Commits on Sep 15, 2024
-
Initialise casaflux%frac_sapwood=1 for use in casa_rplant (#373) (#374)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description casaflux%frac_sapwood needs to be initialised to 1 for the correct calculation of casaflux%crmplant(:,wood) in casa_rplant when cable_user%CALL_climate is not true. This had been done in casa_inout at #274 but this subroutine is only used for offline simulations. This change does the initialisation, in casa_init_pk, for ESM1.5/ESM1.6 cases. Fixes #373 ## Type of change Please delete options that are not relevant. - [X ] Bug fix ## Checklist - [ ] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--374.org.readthedocs.build/en/374/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for b1de4d8 - Browse repository at this point
Copy the full SHA b1de4d8View commit details -
Reinstate dry and cold stress, remove double summation of btran (#372)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description As described in #275, this change reinstates code that had been removed in 2022 with little justification. Reinstating the code provides consistency with ACCESS-ESM1.5 and also with relevant code in src_pop/core/biogeochem. Testing for a small sample of sites showed a large impact if this change was made alone. The related issue (#279) incorrectly calculates btran by summing over layers twice. This calculation is only used if the removed code in #275 is reinstated. Site tests with both changes showed only small differences. Change only impacts runs with CASA-CNP active. Also dealt with corrections to comment for subroutine avgsoil as noted in #279 and subroutine casa_coeffsoil (#277). Fixes #275, #277, #279. ## Type of change Please delete options that are not relevant. - [X ] Bug fix - [ ] New or updated documentation ## Checklist - [ ] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--372.org.readthedocs.build/en/372/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for e97c0ca - Browse repository at this point
Copy the full SHA e97c0caView commit details
Commits on Sep 17, 2024
-
Add src/coupled/AM3 directory (#371)
AM3 application specific see issue #370 Fixes #370 ## Type of change Hopefully will cover CM3 as well - [? ] New or updated documentation ## Checklist - [? ] The new content is accessible and located in the appropriate section. - [?] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--371.org.readthedocs.build/en/371/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 0448257 - Browse repository at this point
Copy the full SHA 0448257View commit details
Commits on Sep 30, 2024
-
Update build-ci version (#409)
The build-ci action has now been fixed (see ACCESS-NRI/build-ci#179). Fixes #408 <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--409.org.readthedocs.build/en/409/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 8f62897 - Browse repository at this point
Copy the full SHA 8f62897View commit details
Commits on Oct 8, 2024
-
Fix compilation with gfortran: use the abort defined in cable_abort_m…
…odule, as gfortran provides a similar function that takes no arguments.
Configuration menu - View commit details
-
Copy full SHA for 66e717a - Browse repository at this point
Copy the full SHA 66e717aView commit details -
Cleanup of mpi drivers by addressing some compiler warnings, includin…
…g unused variables and arguments.
Configuration menu - View commit details
-
Copy full SHA for d0e1995 - Browse repository at this point
Copy the full SHA d0e1995View commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 183df1f - Browse repository at this point
Copy the full SHA 183df1fView commit details
Commits on Oct 17, 2024
-
Remove ESM15 case as inconsistent with current input of xkpsorb (#283) (
#375) # CABLE Thank you for submitting a pull request to the CABLE Project. ## Description Removed two ifdef ESM15 cases related to the use of xkpsorb. The ESM15 code option is inconsistent with how xkpsorb is input in the CABLE3 code. Fixes #283 ## Type of change - [X ] Bug fix ## Checklist - [ ] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [ ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--375.org.readthedocs.build/en/375/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 31db58f - Browse repository at this point
Copy the full SHA 31db58fView commit details -
User guide edit to pftlookup table to note xfPleach hard-wired in CAB…
…LE2.4/ACCESS-ESM1.5
Configuration menu - View commit details
-
Copy full SHA for d0688cb - Browse repository at this point
Copy the full SHA d0688cbView commit details -
Fix gfortran compilation and some warnings (#410)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description This PR fixes compilation with gfortran. I also fixes several compiler warnings (mostly about unused variables) in the MPI master/driver modules. ## Type of change Please delete options that are not relevant. - [X] Bug fix ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--410.org.readthedocs.build/en/410/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 41af6f7 - Browse repository at this point
Copy the full SHA 41af6f7View commit details
Commits on Oct 18, 2024
-
Removed ESM15 version with hard-wired xfpleach parameter, #278 (#422)
# CABLE Thank you for submitting a pull request to the CABLE Project. ## Description In casa_delsoil the evaluation of casaflux%Pleach had two versions, one specific to ESM1.5 (selected via an ifdef) and the alternat for all other cases. Following the code through, the ESM1.5 version had a hard-wired value (1.e-4) for casaflux%fPleach. casaflux%fPleach is filled from xfPleach which is read in from the pftlookup file. The ESM1.5 specific code can be safely removed with no change to the output if xfPleach is set to 1.e-4 in the pftlookup file. Note that there are versions of the pftlookup with xfPleach = 5.e-4. I am not aware of when/who set it to this value and whether it is considered to be better/more realistic. Fixes #278 ## Type of change Please delete options that are not relevant. - [X] Code clean-up ## Checklist - [X ] The new content is accessible and located in the appropriate section. - [ ] I have checked that links are valid and point to the intended content. - [X ] I have checked my code/text and corrected any misspellings Please add a reviewer when ready for review. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--422.org.readthedocs.build/en/422/ <!-- readthedocs-preview cable end -->
Configuration menu - View commit details
-
Copy full SHA for 5c748af - Browse repository at this point
Copy the full SHA 5c748afView commit details