Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ESM15 case as inconsistent with current input of xkpsorb (#283) #375

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

rml599gh
Copy link
Contributor

@rml599gh rml599gh commented Aug 23, 2024

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

Removed two ifdef ESM15 cases related to the use of xkpsorb. The ESM15 code option is inconsistent with
how xkpsorb is input in the CABLE3 code.

Fixes #283

Type of change

  • [X ] Bug fix

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.


📚 Documentation preview 📚: https://cable--375.org.readthedocs.build/en/375/

@rml599gh rml599gh linked an issue Aug 23, 2024 that may be closed by this pull request
@abhaasgoyal abhaasgoyal added the priority:high High priority issues that should be included in the next release. label Aug 30, 2024
@rml599gh
Copy link
Contributor Author

rml599gh commented Oct 7, 2024

I've found it quite difficult to document a clean but short test, given this only applies to ESM1.5 with CABLE3 and online tests diverge due to internal variability once any difference is made. Tests I have done suggest any changes are very small. The code indicates it should be the additional phosphorus pools that are impacted (labile, sorbed and occluded).
This figure shows the difference in globally averaged occluded phosphorus pool by pft (y axis) with no tile fraction weighting after running for 1 month. The difference is from the original ESM1.5 case. Black and blue are cases with the fix described in this pull request (one uses Leuning, the other Medlyn). Green and red are cases without the fix (one uses rootbeta, the other froot). Note that all differences are tiny compared to the pool size.
image

The differences do not separate as clearly for the labile and sorbed phosphorus pools but all differences remain tiny.

@rml599gh rml599gh requested review from a team and Whyborn and removed request for a team October 7, 2024 05:01
@rml599gh rml599gh merged commit 31db58f into main Oct 17, 2024
7 checks passed
@rml599gh rml599gh deleted the 283-esm15-reconciliation-casa_delsoil-phosphorus branch October 17, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High priority issues that should be included in the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM15 reconciliation: casa_delsoil phosphorus
3 participants