Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.bash improvements #297

Merged
merged 6 commits into from
Jun 17, 2024
Merged

build.bash improvements #297

merged 6 commits into from
Jun 17, 2024

Conversation

SeanBryan51
Copy link
Collaborator

@SeanBryan51 SeanBryan51 commented May 17, 2024

This PR addresses feedback specific to build.bash raised in PR: #238

Fixes #296


📚 Documentation preview 📚: https://cable--297.org.readthedocs.build/en/297/

@SeanBryan51 SeanBryan51 linked an issue May 17, 2024 that may be closed by this pull request
6 tasks
@SeanBryan51 SeanBryan51 force-pushed the 296-improvements-to-buildbash branch from f9772b6 to 3a1442e Compare June 17, 2024 03:24
@SeanBryan51 SeanBryan51 marked this pull request as ready for review June 17, 2024 03:28
Copy link
Collaborator

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SeanBryan51 SeanBryan51 merged commit b17cbc0 into main Jun 17, 2024
7 checks passed
@SeanBryan51 SeanBryan51 deleted the 296-improvements-to-buildbash branch June 17, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to build.bash
2 participants