Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -O0 flag from LDFLAGS #197

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Remove -O0 flag from LDFLAGS #197

merged 1 commit into from
Jan 23, 2024

Commits on Jan 22, 2024

  1. Remove -O0 flag from LDFLAGS

    In `build3.sh`, the `-O0` flag (which disables optimisations) is
    included in the `LDFLAGS` variable. This change removes the `-O0` flag
    from `LDFLAGS` so that:
    
    1. Compiler specific flags (non `ld` flags) are removed from `LDFLAGS`
    2. `-O0` flag is not applied for only a subset of source files.
    3. The Makefile rules can be simplified.
    
    See #196 for more details on why the flag should be removed.
    
    Regression tests (bitwise comparison of model output via `nccmp`) show
    that model output is bitwise identical between the current branch and
    the main branch for serial and MPI model runs.
    
    Fixes #196
    SeanBryan51 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6a76f9e View commit details
    Browse the repository at this point in the history