-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
135 cablenml improvements #136
Conversation
I think I'm at the point where I need others to fill in the missing descriptions. |
I suppose cablenml.md should reflect cable.nml, which is in desperate need of revision. At least in the MD we can organise things into sections which will eventually be namelists in their own right. For e.g. Anything to do with filename% and output% doesn't belong in a generic cable.nml. The UM doesn't use any of it. We should have casa.nml and pop.nml (etc etc) files. You're right to get rid of the filename%veg/soil. |
I agree we should put some order into this but this PR was to look at the correctness of the information. I think there is already enough done here and don't need to add. I will put your comment @JhanSrbinovsky as an issue so we can discuss there how to organise the documentation for the namelist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes, especially some duplicated entries. But otherwise it's good work.
I'm having difficulty understanding what |
From memory an alternative soil conductivity implementation from Mark Deker - the Ground Water guy. I did think we were using it in CM2, but it doesn't appear so. |
I don't know what |
|
You can kill this. It is a relic from saving the ACCESS forcing. It has been useful(potentially will be again) as a diagnostic tool. But in no way needed for the model. |
This one is still in the code, largely redundant yet requires further thought. We flipped flopped over the default for a while and it's one of those things that I have to start all over again to understand and remove it. It is a relic from CMIP5 which initially started from a dead cold state, i.e. tiled soils etc didn't exist in the UM, had no values, let alone spun up. Then it morphed as CMIP5 UM didn't keep track the date and we needed to dodge it (we had to have a post-processing date tracker - it was crazy). Then it resurfaced in CMIP6 with a sightly different usage requirement again. Gives me a headache just thinking about it. Kill it and maybe @ccarouge can flag it? |
…some more descriptions.
Many thanks! The only other entries I can't make sense of are the GW related flags.
Can someone that knows these well can describe them for me? |
@JhanSrbinovsky I'm not certain what you mean by "kill it" and "flag it". I would assume "kill it" means remove it? But "flag it", I have no idea. |
I think Tammas has not bothered with documentation of it (the runtime_coupled flag) as it is basically redundant. And by flag it I mean keep note of it as something to remove from the code (at a later date is fine. Its not breaking anything)
Jhan
From: Claire Carouge ***@***.***>
Date: Friday, 14 July 2023 at 4:19 pm
To: CABLE-LSM/CABLE ***@***.***>
Cc: Srbinovsky, Jhan (Environment, Aspendale) ***@***.***>, Mention ***@***.***>
Subject: Re: [CABLE-LSM/CABLE] 135 cablenml improvements (PR #136)
@JhanSrbinovsky<https://github.com/JhanSrbinovsky> I'm not certain what you mean by "kill it" and "flag it". I would assume "kill it" means remove it? But "flag it", I have no idea.
—
Reply to this email directly, view it on GitHub<#136 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB2SBWORWEKHRWA7UHR47V3XQDQF7ANCNFSM6AAAAAAZVBRHTM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
OK. So I've added an issue in this repository (#137 ) to add the deprecated namelist options to the list Ramzi has started in the User Guide. We can add to that issue as we find other such options. |
All I know is that it adds a litter layer on top of the soil surface. It was implemented because CABLE was/is over-evaporating and this reduces the evaporation. But that might not be useful information for the User Guide.
This is to turn on an alternate soil model that takes into account the groundwater. @bibivking How best would you describe this in the documentation when describing the namelist options?
This is an evaporation scheme from Dani Or. But I don't know if there is a reference for it. @bibivking Do you know more about this scheme?
I would think this one will disappear when Ramzi is finished merging the GW scheme. The technical phase should be finished by the end of August, so I would put this in deprecated and not list it here. @rkutteh any thoughts on this namelist option? Have you encountered it so far in your work merging the versions? |
cable_user%litter Of the four above, the only one I have not encountered yet is the last one (but I am midway through the work still...). The second and third are definitely in use and needed. I will get back to this thread in a month or so when I am finished with moving the GW into the trunk and say more... |
I have updated everything with the information provided, thanks folks! It looks like all the namelist variables here have some sort of description. |
@tammasloughran I don't think we want to worry about an order now. We will want to split this huge namelist into several namelists soon. The ordering would happen then. The webpage rendered is static so no ordering possible there. |
@tammasloughran Is it ready for another review? If so, can you request it? Either look at the "Reviewers" menu on the top right and click the "2 arrows in a circle" icon, a bit like this: 🔄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have minor suggestions to make things a bit clearer.
I would prefer if the table wasn't between the example for offline and ACCESS simulations. So if you can move either the table first and the examples after or the other way around that would be great.
But I have approved as is so feel free to merge in when you think it is ready.
Co-authored-by: Claire Carouge <[email protected]>
I'm not sure what to do about the link checks. At first I thought there was some problem with the DOI redirection but changing it to a full URI didn't make any difference. |
09bcf4b
to
c53f9bb
Compare
It's possible to ignore specific links in the link checker: https://github.com/gaurav-nelson/github-action-markdown-link-check#disable-check-for-some-links . So I've added this for the link to the paper. I've changed the link to go via doi.org so it will stay valid even if the journal is sold. |
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
The cable.nml documentation can be improved.
Fixes #135
Type of change
Please delete options that are not relevant.
Checklist
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--136.org.readthedocs.build/en/136/