Calendar attribute independent from leap years (#195)

# CABLE

Thank you for submitting a pull request to the CABLE Project.

## Description

Removes the dependency of the calendar attribute on the fact we are
running a leap year or not. So output files from a same configuration
will have the same calendar attribute for all years.
Fixes #187 

## Testing
**Setup:** ran a global simulation with CRU JRA forcing (using gswp3
namelist settings) with both this branch and the main branch for 2
years: normal and leap year.

**Results:** `cdo diffn` indicates the variables in the cable_out.nc
files are identical. But the calendar attribute for `time` is different
in the non-leap year: `noleap` with the code from the main branch,
`standard` with the code from this branch.

## Type of change

Please delete options that are not relevant.

- [X] Bug fix

## Documentation

No changes to the documentation are required for this change.

Please add a reviewer when ready for review.


<!-- readthedocs-preview cable start -->
----
📚 Documentation preview 📚:
https://cable--195.org.readthedocs.build/en/195/

<!-- readthedocs-preview cable end -->

---------

Co-authored-by: ccc561 <ccc561@b483b3d9-cc7d-4f55-9e4c-b4562452379e>
Co-authored-by: C. Carouge <[email protected]>

src/offline/cable_driver.F90

@@ -464,13 +464,18 @@ PROGRAM cable_offline_driver
 
         YEAR: DO YYYY= CABLE_USER%YearStart,  CABLE_USER%YearEnd
            CurYear = YYYY
-           IF ( leaps .AND. IS_LEAPYEAR( YYYY ) ) THEN
-              LOY = 366
+
+           !ccc Set "calendar" for netcdf time attribute and 
+           ! number of days in the year
+           calendar = "noleap"
+           LOY = 365
+           IF ( leaps ) THEN
               calendar = "standard"
-           ELSE
-              LOY = 365
-              calendar = "noleap"
-           ENDIF
+           END IF
+           IF ( IS_LEAPYEAR( YYYY ) ) THEN
+            LOY = 366
+           END IF
+
            ! Check for gswp run
            IF ( TRIM(cable_user%MetType) .EQ. 'gswp' ) THEN
               ncciy = CurYear
@@ -503,12 +508,6 @@ PROGRAM cable_offline_driver
                  kend	   = ktauday * LOY
               ENDIF
 
-              IF (leaps) THEN
-                 calendar = "standard"
-              ELSE
-                 calendar = "noleap"
-              ENDIF
-
            ELSE IF ( TRIM(cable_user%MetType) .EQ. 'plum' ) THEN
               ! PLUME experiment setup using WATCH
               IF ( CALL1 ) THEN
@@ -530,12 +529,6 @@ PROGRAM cable_offline_driver
                  str3 = ADJUSTL(str3)
                  timeunits="seconds since "//TRIM(str1)//"-"//TRIM(str2)//"-"//TRIM(str3)//" &
                       00:00"
-                 IF (leaps) THEN
-                    calendar = "standard"
-                 ELSE
-                    calendar = "noleap"
-                 ENDIF
-
               ENDIF
               IF ( .NOT. PLUME%LeapYears ) LOY = 365
               kend = NINT(24.0*3600.0/dels) * LOY
@@ -582,9 +575,6 @@ PROGRAM cable_offline_driver
                  calendar = 'standard'
 
               ENDIF
-              LOY = 365
-
-              IF (IS_LEAPYEAR(CurYear)) LOY = 366
               kend = NINT(24.0*3600.0/dels) * LOY
               ! get koffset to add to time-step of sitemet
               IF (TRIM(site%RunType)=='historical') THEN

src/offline/cable_iovars.F90

@@ -35,7 +35,8 @@ MODULE cable_IO_vars_module
 
   CHARACTER(LEN=200) :: timeunits ! timing info read from nc file
 
-  CHARACTER(LEN=10) :: calendar ! 'noleap' for no leap years, 'standard' for leap years
+  CHARACTER(LEN=10) :: calendar ! 'standard' if using leap years (set by 
+                                ! leaps namelist option), else 'noleap'
 
   CHARACTER(LEN=3) :: time_coord ! GMT or LOCal time variables
 

src/offline/cable_mpimaster.F90

@@ -500,10 +500,9 @@ SUBROUTINE mpidrv_master (comm)
 
           CurYear = YYYY
 
+          LOY = 365
           IF ( leaps .AND. IS_LEAPYEAR( YYYY ) ) THEN
              LOY = 366
-          ELSE
-             LOY = 365
           ENDIF
 
           IF ( TRIM(cable_user%MetType) .EQ. 'plum' ) THEN
@@ -562,11 +561,6 @@ SUBROUTINE mpidrv_master (comm)
              WRITE(*,*) 'Looking for global offline run info.'
              CALL open_met_file( dels, koffset, kend, spinup, CTFRZ )
 
-             IF ( leaps .AND. IS_LEAPYEAR( YYYY ) ) THEN
-                calendar = "standard"
-             ELSE
-                calendar = "noleap"
-             ENDIF
 
            ELSE IF ( globalMetfile%l_gpcc ) THEN
              ncciy = CurYear
@@ -575,6 +569,14 @@ SUBROUTINE mpidrv_master (comm)
 
           ENDIF
 
+          !ccc Set calendar attribute: dependant on the value of `leaps`
+          ! that is set in the MetType if conditions above.
+          calendar = "noleap"
+          IF ( leaps ) THEN
+             calendar = "standard"
+          ENDIF
+
+
           ! somethings (e.g. CASA-CNP) only need to be done once per day
           ktauday=INT(24.0*3600.0/dels)