-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community Grants section - Customize apply button and feedback depending on connected address #116
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I think I'm going to revert that one, the green color looks really bad in some admin actions 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tysm @Pabl0cks !! Working great ! Just pushed a couple commits :
- Cleand / simplified it a bit: inlined the logic for ApplyButton and created FeedBackMessage component just to avoid lot ternaries in parent component itself
- Centered the "Do you Qualify?" box on mobile
- Allowed people to connect to wallet from Communtiy Grants sections itself and also added a loader while we are fetching buildersData to from backend to check for eligibility (The on local firebase instance was close to none but on prod there is very small delay)
Demo video :
Screen.Recording.2024-04-18.at.6.49.16.PM.mov
Also a small nitpick : Should we decrease padding a bit of left section so that it decrease the height of whole Community section ?
<div className="my-4 lg:py-16 space-y-2 lg:max-w-[40%] flex flex-col items-center lg:items-start"> |
Because currently the patches in the right section (Who, Process, Amount etc) seems a bit apart from each other
But yeah maybe we could handle it in different PR 🙌
This is great! Thank you both <33 Pushed a couple of little things. One is to make this better:
We can iterate in another PR (still some resolution around 1100 when the patches overlap) |
Thanks @technophile-04 and @carletex for the review!! This one was tough, sorry you had to get your hands dirty!! 😢 Your implementation is much cleaner Shiv, love it!! ❤ |
Fixes #66
A few notes to check:
<Link>
for BG members, not sure if that's a good practice.Hope the code is not too messy, sorry just in case lol
https://www.loom.com/share/baf0788d88514003bc5c1513b2b50f1d?sid=aa38c661-61c3-44a5-8755-b1b2209860d7