Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Grants section - Customize apply button and feedback depending on connected address #116

Merged
merged 10 commits into from
Apr 18, 2024

Conversation

Pabl0cks
Copy link
Member

@Pabl0cks Pabl0cks commented Apr 17, 2024

Fixes #66

A few notes to check:

  • Changed warning and success color tones to match the design, since they were mostly used in Admin pages, that way don't need to define a new color manually for this. (Not sure if that's the right practice tho!)
  • Created a new component just to leave all the "messy" conditions there.
  • Created a "fake" button for non-bg members, and kept the <Link> for BG members, not sure if that's a good practice.
  • At some point I thought it may be a good idea to fix the "Connect" header so you don't have to scroll up to connect, but then I thought that would not be the common use case, and discarded the idea. LMK if you think is needed! 🙌

Hope the code is not too messy, sorry just in case lol

https://www.loom.com/share/baf0788d88514003bc5c1513b2b50f1d?sid=aa38c661-61c3-44a5-8755-b1b2209860d7

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 2:09pm

@Pabl0cks Pabl0cks changed the title Customized apply button and feedback messages depending on connected user Community Grants section - Customize apply button and feedback depending on connected address Apr 17, 2024
@Pabl0cks
Copy link
Member Author

Changed warning and success color tones to match the design, since they were mostly used in Admin pages, that way don't need to define a new color manually for this. (Not sure if that's the right practice tho!)

I think I'm going to revert that one, the green color looks really bad in some admin actions 😢

Copy link
Member

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm @Pabl0cks !! Working great ! Just pushed a couple commits :

  1. Cleand / simplified it a bit: inlined the logic for ApplyButton and created FeedBackMessage component just to avoid lot ternaries in parent component itself
  2. Centered the "Do you Qualify?" box on mobile
  3. Allowed people to connect to wallet from Communtiy Grants sections itself and also added a loader while we are fetching buildersData to from backend to check for eligibility (The on local firebase instance was close to none but on prod there is very small delay)
Demo video :
Screen.Recording.2024-04-18.at.6.49.16.PM.mov

Also a small nitpick : Should we decrease padding a bit of left section so that it decrease the height of whole Community section ?

<div className="my-4 lg:py-16 space-y-2 lg:max-w-[40%] flex flex-col items-center lg:items-start">

Because currently the patches in the right section (Who, Process, Amount etc) seems a bit apart from each other

But yeah maybe we could handle it in different PR 🙌

@carletex
Copy link
Contributor

This is great! Thank you both <33

Pushed a couple of little things. One is to make this better:

Because currently the patches in the right section (Who, Process, Amount etc) seems a bit apart from each other

We can iterate in another PR (still some resolution around 1100 when the patches overlap)

@carletex carletex merged commit 9e1d0f9 into main Apr 18, 2024
2 of 3 checks passed
@carletex carletex deleted the update/com-grants-feedback branch April 18, 2024 14:06
@Pabl0cks
Copy link
Member Author

Thanks @technophile-04 and @carletex for the review!! This one was tough, sorry you had to get your hands dirty!! 😢

Your implementation is much cleaner Shiv, love it!! ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a visual element to Community Grants section to show extra info depending on user status
3 participants