Issue 6 - Resolve Show connected wallet info #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danitome24
changed the title
danitome24
changed the title
|
Nice texts in your implementation, but I would place it somewhere else. Now it can block content on the page. See screenshot: Having it either in the header or in the wallet dropdown are both good solutions I think. |
|
good point @arjanjohan!! I will try to fix it. I did it to practice, so I'm just happy with feedback even if it don't get merged. :) Thanks for this comment. |
|
I just changed position of div from fixed to flex center on navbar. Now is blocking nothing. 
|
|
Closed by choosing another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a solution for issue #5 where I display some messages depending on wallet status.
Additional Information
Related Issues
Closes #5
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: 0xaa4C60b784E2b3E485035399bF1b1aBDeD66A60f