This repository has been archived by the owner on Nov 26, 2018. It is now read-only.
Features/spring cleanup #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion_name to bot instead of empty string.
…features/better-postgresql-connection-handling
…ction-handling Features/better postgresql connection handling
…r 30s without messages from the server.
…s long period (15 min) of inactivity.
… silent network every 150 min. This should be configurable per chat bot
…t. Try to reconnect this bot instead of just calling bot.Close()
… and expose it as expvar.
…e sure that the bot.socket has been properly initialized
…t after 4 missed ping.
…e it as soon as possible instead of taking it for a complete method
… quit chan struct{} this reduce the number of place where I need to lock
… think it is leaking postgres connection
…utside the ircBot.init() to make testing easier and less hackish. ircBot.init() now takes a conn as argument.
…o drop the first tls connection that is establish by the ircBot.connect
| @@ -0,0 +1,27 @@ | |||
| -----BEGIN RSA PRIVATE KEY----- | |||
There was a problem hiding this comment.
Not the author, but as noted above, it's a self-signed cert, probably used for testing. It isn't used for anything in production.
There was a problem hiding this comment.
Just seems overall that it would be better to just leave the readme explaining how to get here rather than distributing a default cert even if the intention is for testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.