Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 0conf setting #649

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add 0conf setting #649

wants to merge 1 commit into from

Conversation

dni
Copy link
Member

@dni dni commented Jul 23, 2024

wip

Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Jul 23, 2024 11:19am
webapp-mainnet ✅ Ready (Inspect) Visit Preview Jul 23, 2024 11:19am

Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the implementation of that feature?

@@ -0,0 +1,24 @@
import { useGlobalContext } from "../../context/Global";

const ZeroconfSetting = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fourth true/false switch. Let's unify those with one base component

zeroconf: "Zeroconf",
zeroconf_tooltip: "Enable or disable zeroconf",
enable_zeroconf: "Enable Zeroconf",
enable_zeroconf_tooltip: "Enable or disable zeroconf larger desc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@@ -204,6 +204,10 @@ const dict = {
"Disables prompts to download refund file and other confirmation steps",
error_starting_qr_scanner:
"Couldn't access camera, please check permissions!",
zeroconf: "Zeroconf",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call it 0-conf in labels

@dni
Copy link
Member Author

dni commented Jul 24, 2024

still wip, i only through bare bones out there

@dni dni marked this pull request as draft July 24, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants