feat: improve embedding of swapbox #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Shall we push this one over the finish line? We recently had an integration that wanted "a simplified webview with prefilled swap data" |
|
created an example embed page https://dni.github.io/boltz-webapp-embed/ |
|
really looking forward to this merging to main, because it's one of the fundamental parts that our project needs right now! :) |
kilrau
requested changes
Aug 13, 2024
michael1011
requested changes
Aug 13, 2024
|
I'm looking forward to have a few examples ready of URLs with different strategies for swaps. This will help also future devs with integrating with Boltz. So far good job and I'm super happy with the responsiveness of you guys! :) |
michael1011
force-pushed
the
feat-url-params-3
branch
from
d62654c
to
95e6c7e
Compare
michael1011
force-pushed
the
feat-url-params-3
branch
from
95e6c7e
to
f2b57fb
Compare
michael1011
force-pushed
the
feat-url-params-3
branch
from
f2b57fb
to
98b412d
Compare
michael1011
force-pushed
the
feat-url-params-3
branch
from
98b412d
to
ed5b350
Compare
maybeast
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #334
adds invoice, address, asset, sendAmount, receiveAmount