Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to ignore datatypes while validating #265

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mgeplf
Copy link
Contributor

@mgeplf mgeplf commented Apr 5, 2024

  • teach the bluepysnap validate-circuit and bluepysnap validate-simulation the ability to --ignore-datatype-errors so that mismatches of datatypes to the specification are ignored

Copy link
Contributor

@joni-herttuainen joni-herttuainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bluepysnap/cli.py Show resolved Hide resolved
* teach the `bluepysnap validate-circuit` and `bluepysnap validate-simulation`
the ability to `--ignore-datatype-errors` so that mismatches of datatypes to
the specification are ignored
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fb301e2) to head (32d2bde).
Report is 1 commits behind head on master.

❗ Current head 32d2bde differs from pull request most recent head 8d31460. Consider uploading reports for the commit 8d31460 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #265   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines         2743      2739    -4     
=========================================
- Hits          2743      2739    -4     
Flag Coverage Δ
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgeplf mgeplf merged commit 06d9e52 into master Apr 18, 2024
4 checks passed
@mgeplf mgeplf deleted the ignore-datatype-errors branch April 18, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants