[BBPBGLIB-1145] Write gids without offset in WholeCell LB complexity file #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Looks promising! |
|
I tested locally the SSCx simulation that had the issue and also launched the long tests, to be sure we don't have the problem found in the past: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Long tests are passing also! |
WeinaJi
previously approved these changes
Apr 5, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jorblancoa
force-pushed
the
jblanco/loadbalance_raw_gids
branch
from
a5071b9
to
e997630
Compare
jorblancoa
changed the title
WeinaJi
reviewed
Apr 9, 2024
This comment has been minimized.
This comment has been minimized.
jorblancoa
force-pushed
the
jblanco/loadbalance_raw_gids
branch
from
3eb2732
to
ad5eab3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ferdonline
reviewed
Apr 10, 2024
This comment has been minimized.
This comment has been minimized.
jorblancoa
force-pushed
the
jblanco/loadbalance_raw_gids
branch
from
cbf5333
to
61684ef
Compare
This comment has been minimized.
This comment has been minimized.
cell.gid contains raw_gid
jorblancoa
force-pushed
the
jblanco/loadbalance_raw_gids
branch
from
61684ef
to
7407274
Compare
WeinaJi
approved these changes
Apr 15, 2024
|
Logfiles from GitLab pipeline #205268 (:white_check_mark:) have been uploaded here! Status and direct links: |
4 tasks
WeinaJi
added a commit
that referenced
this pull request
May 13, 2024
## Context After #148, we are writing raw gids in `Nd.BalanceInfo` instead of final gids with offsets. Such change is missing in `record_spikes()` leading to no spike written in the report with NEURON while lb mode is enabled. ## Scope Fix in the function `cell_distributer.py: record_spikes`. ## Testing check spikes in `test_loadbal_integration` ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
atemerev
pushed a commit
that referenced
this pull request
May 24, 2024
…file (#148) ## Context Addresses issue highlighted in BBPBGLIB-1145, where the offsets were being calculated before the load balancing, causing issue sometimes when having virtual populations alphabetically ordered before the first real population. ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
atemerev
pushed a commit
that referenced
this pull request
May 24, 2024
## Context After #148, we are writing raw gids in `Nd.BalanceInfo` instead of final gids with offsets. Such change is missing in `record_spikes()` leading to no spike written in the report with NEURON while lb mode is enabled. ## Scope Fix in the function `cell_distributer.py: record_spikes`. ## Testing check spikes in `test_loadbal_integration` ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
WeinaJi
pushed a commit
that referenced
this pull request
Oct 14, 2024
…file (#148) ## Context Addresses issue highlighted in BBPBGLIB-1145, where the offsets were being calculated before the load balancing, causing issue sometimes when having virtual populations alphabetically ordered before the first real population. ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
WeinaJi
added a commit
that referenced
this pull request
Oct 14, 2024
## Context After #148, we are writing raw gids in `Nd.BalanceInfo` instead of final gids with offsets. Such change is missing in `record_spikes()` leading to no spike written in the report with NEURON while lb mode is enabled. ## Scope Fix in the function `cell_distributer.py: record_spikes`. ## Testing check spikes in `test_loadbal_integration` ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Addresses issue highlighted in BBPBGLIB-1145, where the offsets were being calculated before the load balancing, causing issue sometimes when having virtual populations alphabetically ordered before the first real population.
Review