Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to solve crashes when running on certain amount of ranks #141

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

st4rl3ss
Copy link
Contributor

@st4rl3ss st4rl3ss commented Mar 13, 2024

Context

Simple hotfix to solve issues in lb-mode=Memory when ran on certain amounts of ranks.

Scope

Just a small fix to solve crashing issues.

Testing

No further testing necessary

Review

  • PR description is complete
  • Coding style (imports, function length, New functions, classes or files) are good
  • Unit/Scientific test added
  • Updated Readme, in-code, developer documentation

@bbpbuildbot

This comment has been minimized.

@st4rl3ss st4rl3ss force-pushed the bellotta/get_num_target_ranks_hotfix branch from 9f0697e to 0091f54 Compare March 13, 2024 15:37
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot
Copy link

@st4rl3ss st4rl3ss merged commit 25f54c6 into main Apr 3, 2024
6 checks passed
@st4rl3ss st4rl3ss deleted the bellotta/get_num_target_ranks_hotfix branch April 3, 2024 09:51
WeinaJi pushed a commit that referenced this pull request Oct 14, 2024
## Context
Simple hotfix to solve issues in `lb-mode=Memory` when ran on certain
amounts of ranks.

## Scope
Just a small fix to solve crashing issues.

## Testing
No further testing necessary

## Review
* [x] PR description is complete
* [x] Coding style (imports, function length, New functions, classes or
files) are good
* [x] Unit/Scientific test added
* [x] Updated Readme, in-code, developer documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants