[BBPBGLIB-1122] Removing legacy RNGs, leaving only Random123 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ferdonline
pushed a commit
to BlueBrain/neurodamus-models
that referenced
this pull request
Mar 13, 2024
….hoc Currently, UPMCELLRAN and COMPATIBILITY RNGs are deprecated and should not be used. Their support is now being removed from Neurodamus, and their uses needs to be removed from HOC files here as well. Related to BlueBrain/neurodamus/pull/136
ferdonline
pushed a commit
to BlueBrain/neurodamus-models
that referenced
this pull request
Mar 13, 2024
….hoc Currently, UPMCELLRAN and COMPATIBILITY RNGs are deprecated and should not be used. Their support is now being removed from Neurodamus, and their uses needs to be removed from HOC files here as well. Related to BlueBrain/neurodamus/pull/136
This comment has been minimized.
This comment has been minimized.
WeinaJi
force-pushed
the
atemerev/rng-random123-only
branch
from
a05e4c4
to
2e7f35d
Compare
WeinaJi
reviewed
Apr 29, 2024
WeinaJi
force-pushed
the
atemerev/rng-random123-only
branch
from
2e7f35d
to
a6baddd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
WeinaJi
reviewed
May 24, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
WeinaJi
reviewed
May 24, 2024
This comment has been minimized.
This comment has been minimized.
WeinaJi
reviewed
May 27, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
atemerev
force-pushed
the
atemerev/rng-random123-only
branch
from
3f5ca1a
to
07f0e06
Compare
|
Logfiles from GitLab pipeline #213059 (:white_check_mark:) have been uploaded here! Status and direct links: |
WeinaJi
approved these changes
May 28, 2024
WeinaJi
pushed a commit
that referenced
this pull request
Oct 14, 2024
Removing legacy RNGs and the ability to configure RNGs. Random123 is chosen everywhere as the only option. ## Context RNG types differing from Random123 are no longer used and removed from everywhere (including configuration). ## Scope RNGSettings.hoc (removed RNGmode and all related constants), configuration.py, random.py, and corresponding usages. ## Testing Write a test that raises exception in attempt to configure RNG mode. ## Review * [X] PR description is complete * [X] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing legacy RNGs and the ability to configure RNGs. Random123 is chosen everywhere as the only option.
Context
RNG types differing from Random123 are no longer used and removed from everywhere (including configuration).
Scope
RNGSettings.hoc (removed RNGmode and all related constants), configuration.py, random.py, and corresponding usages.
Testing
Write a test that raises exception in attempt to configure RNG mode.
Review