Skip to content

Commit

Permalink
[BBPGBLIB-1147] Fixes crashes with KeyError when running sonataconf-s…
Browse files Browse the repository at this point in the history
…scx-O1 circuit on dry run (#149)

## Context
Fixes the crash when running sonataconf-sscx-O1 circuit on dry run as
detailed in: https://bbpteam.epfl.ch/project/issues/browse/BBPBGLIB-1147
The fix is pretty simple and just involves iterating over the
`meinfo.keys()` instead of the whole `gidvec` since not all the data
metadata is loaded in dry run.

## Scope
Just a simple fix.

## Testing
No new testing needed.

## Review
* [x] PR description is complete
* [x] Coding style (imports, function length, New functions, classes or
files) are good
* [x] Unit/Scientific test added
* [x] Updated Readme, in-code, developer documentation
  • Loading branch information
st4rl3ss authored Apr 8, 2024
1 parent 25f54c6 commit 325abfb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion neurodamus/io/cell_readers.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def validate_property(prop_name):
prop_data = node_pop.get_dynamics_attribute(prop_name, node_sel)
else:
prop_data = node_pop.get_attribute(prop_name, node_sel)
for gid, val in zip(gidvec, prop_data):
for gid, val in zip(meinfos.keys(), prop_data):
meinfos[gid].extra_attrs[prop_name] = val

return gidvec, meinfos, fullsize
Expand Down

0 comments on commit 325abfb

Please sign in to comment.