Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement --throttle #51

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Reimplement --throttle #51

merged 1 commit into from
Aug 2, 2023

Conversation

SAERXCIT
Copy link

@SAERXCIT SAERXCIT commented Jun 5, 2023

Hi!

The --throttle option seems to actually be ineffective. It only seems to be used in the BaseContext.DoDelay() method. However, this method does not seem to be called anywhere:

$ grep -r DoDelay --include='*.cs'
src/BaseContext.cs:        public async Task DoDelay()   // Function definition
src/Client/Context.cs:        Task DoDelay();            // Definition in IContext interface

This PR implements it in the ObjectProcessors.ProcessComputerObject() Task, where it will wait for the provided throttle value before starting to perform network requests to the target machine.

This in turn allows the user to control SharpHound's network throughput, as I think was the original intent of this option.

Cheers!

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@SAERXCIT
Copy link
Author

SAERXCIT commented Jun 5, 2023

I have read the CLA Document and I hereby sign the CLA

@SAERXCIT
Copy link
Author

SAERXCIT commented Jun 5, 2023

recheck

@rvazarkar rvazarkar merged commit a7d9c40 into BloodHoundAD:dev Aug 2, 2023
@rvazarkar
Copy link
Contributor

Thanks for the MR!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants