Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The
--throttle
option seems to actually be ineffective. It only seems to be used in theBaseContext.DoDelay()
method. However, this method does not seem to be called anywhere:This PR implements it in the
ObjectProcessors.ProcessComputerObject()
Task, where it will wait for the provided throttle value before starting to perform network requests to the target machine.This in turn allows the user to control SharpHound's network throughput, as I think was the original intent of this option.
Cheers!