Add options for non-Python projects #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 95.53% 95.34% -0.19%
==========================================
Files 8 8
Lines 716 730 +14
==========================================
+ Hits 684 696 +12
- Misses 32 34 +2
☔ View full report in Codecov by Sentry. |
sduenas
requested changes
Oct 9, 2023
| @@ -0,0 +1,12 @@ | |||
| --- | |||
There was a problem hiding this comment.
I see this as two features. Why don't you split it in two changelog files? I would also do the same with the commits.
Adds the '--current-version' argument to 'semverup'. This uses the given version number instead of looking for it on '_version.py'. Signed-off-by: Eva Millán <[email protected]>
Adds the '--add-all' option to the 'publish' command to include all changed files in the release commit. Signed-off-by: Eva Millán <[email protected]>
evamillan
force-pushed
the
non-python-projects
branch
from
66932e8
to
a5156f0
Compare
|
@sduenas I updated the PR with the changes you requested. |
sduenas
reviewed
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--current-versionarg to thesemverupcommand and the--add-allflag topublishto avoid needing to use Python package specific files like_version.pyorpyproject.toml.