Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate fix #21

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Deprecate fix #21

merged 3 commits into from
Aug 29, 2024

Conversation

epark272
Copy link
Contributor

ActionUpdateThread.OLD_EDT is being deprecated, and errors will pop up when running IntelliJ (even when the plugin is not actively used). Here is the error message:

com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'edu.berkeley.cs61b.plugin.CheckStyleAction' must override `getActionUpdateThread()` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: edu.berkeley.cs61b.plugin]
	at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
	at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:90)
	at com.intellij.diagnostic.PluginException.reportDeprecatedUsage(PluginException.java:125)
	at com.intellij.openapi.actionSystem.ActionUpdateThreadAware.getActionUpdateThread(ActionUpdateThreadAware.java:21)
	at com.intellij.openapi.actionSystem.AnAction.getActionUpdateThread(AnAction.java:201)

Some points of concern:

  • I don't know how to test the plugin locally, so I did not do any testing.
  • ActionUpdateThread.BGT should be fine for our use cases?
  • I was unable to find any documentation on ActionUpdateThread and which version it was being deprecated from. There is a small but unlikely (in my opinion) chance that this will break the plugin on older versions of IntelliJ.

@davidmyang davidmyang merged commit e100be4 into master Aug 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants