Fork Sync Branch 16.0 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inverted dates make no functional sense, but when they do happen, this change allows displaying them as single points in the timeline (same as when begin=end). We currently do have such demo data when installing project_timeline.
This commit fixes redraw issues when setting a `mode` attribute in the `timeline` view tag. This mode specifies a default scale one would want to set; same as when clicking on Day/Week/Month buttons at the top of the view. Initial rendering had issues here because data was loaded too soon, before the timeline component was rendered/ready. The fix is to load data into the component only after initial redraw event, called `changed` (see <https://visjs.github.io/vis-timeline/docs/timeline/#Events>). There was old code attempting to call `on_scale_xxx_clicked` methods at load time to simulate clicks on these Day/Week/Month buttons, but these methods have been renamed so this code is no longer working. This commit also removes the `current_window` instance variable, not needed and actually confusing as the timeline component already maintains its own start/end information (which we can query with `timeline.getWindow()`).
In addition to security rights (was already implemented), now follow `create="0"` / `edit="0"` / `delete="0"` attributes one can set onto the `timeline` tag, same as in other Odoo views.
Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_editor_class_selector Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_editor_class_selector/it/
…s not present Go to the website Open the editor Add text and select it, a traceback is shown
sireko
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.