Feat/provisional evidence 20240429 #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 4 new fields to the variant model, with migration to update the database
First implementation of the provisional evidence frontend gui
Did a cleaner and smaller implementation of the provisional evidence frontend.
Added tooltips and reference text.
* Remove release hyperlinks
Files changed:
Releases.js:
Pages affected:
https://brcaexchange.org/releases
https://brcaexchange.org/release/{release id}
Removes hyperlinks in the listing of counts for the number of variants new, updated, removed etc for each release in the table on the main page as well as each individual release page. Counts remain but are no longer clickable.
* Remove supporter logos
Files changed:
logos.js
index.js
Pages affected:
https://brcaexchange.org
https://brcaexchange.org/about/thisSite
Remove logos for NIH, NCI, and ITCR. These were under the "Currently Supported By" header.
In addition, only show the "Currently Supported By" header when there are any logos underneath it; hide it when that section is empty.
* Remove BIC tile
Files changed:
VariantTable.js
content.js
index.js
clinical-significance-bic.md (removed)
Pages affected:
https://brcaexchange.org/variant/{variant id}
Removes the deprected "Clinical Significance (BIC)" tile from the Variant Details view.
melissacline
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Is this a typo correction? Good catch!
e-t-k
force-pushed
the
feat/provisional-evidence-20240429
branch
from
fc3fede
to
5866e48
Compare
|
@melissacline Added the text per #1507 - ready for final review and/or merge! The pipeline CI failure is the same as the previous failures recently, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Provisional Evidence fields + GUI + small gui changes.
Adds four fields to the variant table in the backend:
Provisional_Evidence_Code_Popfreq
Provisional_Evidence_Description_Popfreq
Provisional_Evidence_Code_Bioinfo
Provisional_Evidence_Description_Bioinfo
For the Popfreq fields, adds a sub-tile on to the Allele Frequency Reference Sets Tile which displays their information. (Bioinfo fields currently unused.)
Also adds a few miscellaneous GUI changes: (see 9128335 ):