Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the points2binaryimage tool into points2labelimage #136

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

kostrykin
Copy link
Member

@kostrykin kostrykin commented Sep 27, 2024

Previously, the points2labelimage tool did very much the same as points2binaryimage, except that it used different labels. Merging the points2binaryimage tool into the more general points2labelimage tool will reduce redundant code and facilitate future maintenance. This PR also adds the changes from #133 to the points2labelimage tool, and the functionality to use custom labels parsed from the tabular point file.

Another issue with the previous points2labelimage tool was that it required an "original label image" as a mandatory input, but this image was only used to deduce the shape of the output image. Not very user-friendly, this now is not required anymore.

@bgruening Can you please mark the points2binaryimage tool as deprecated and hidden? I have added it to the list #93 that you asked me to create for you a while ago :)

Fix #134


Bildschirmfoto 2024-09-27 um 15 10 27

FOR THE CONTRIBUTOR — Please fill out if applicable

Please make sure you have read the CONTRIBUTING.md document (last updated: 2024/04/23).

  • License permits unrestricted use (educational + commercial).

If this PR adds or updates a tool or tool collection:

@bgruening
Copy link
Collaborator

@bgruening Can you please mark the points2binaryimage tool as deprecated and hidden? I have added it to the list #93 that you asked me to create for you a while ago :)

Ok, I will work on this asap and notify you here.

@bgruening bgruening merged commit 6fc9ab8 into BMCV:master Sep 27, 2024
11 checks passed
@kostrykin kostrykin deleted the points2label/dev branch September 27, 2024 18:22
@bgruening
Copy link
Collaborator

Ok, should be done by tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge points2labelimage tool into points2binaryimage
2 participants