Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RegisterSlicesDeepSliceAbstractCommand.java #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PolarBean
Copy link

TAs discussed over email. to prepare for future versions of DeepSlice where these parameters will want to match the target atlas resolution.

To prepare for future versions of DeepSlice where these parameters will want to match the target atlas resolution.
@NicoKiaru
Copy link
Member

Thanks! I think I will need to handle different versions and whether that run locally or remotely with the website.

A simple option is to let this parameter to the user and he has to deal with it. This has the advantage to be flexible. The alternative is to be clever... Is the update on the server already there ? Is the deepslice repo updated with it or will the new version be only available remotely ?

@PolarBean
Copy link
Author

DeepSlice can handle any resolution so it won't affect it at the moment (no need for knowing which version is being used), I recommend lower res because otherwise it fills up the server too fast. I want to integrate user data into a future model and so if all user data at present is low resolution then I will be limited in what I can use. No worries if you want to keep it how it currently is!

@NicoKiaru
Copy link
Member

Ok, now I get it. Two points on this:

  • do you plan to support 16-bits (potentially multichannel) images or should the images be still 8-bit rgb ?
  • do you plan to share at some point the data you collect ?

@PolarBean
Copy link
Author

  • No plans to support 16 bit
  • No I won't share the data either as some people have expressed reservations on this. I will just use it to train new models and these will be released in the same manner as the existing ones.

@NicoKiaru
Copy link
Member

Ok, then I think I need to spend a bit more time on a proper warning about the saturated images. The issue about white background images could be nice to tackle as well. I need to think about a convenient way for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants