Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mount /etc/passwd and /etc/group files #162

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

zioproto
Copy link
Contributor

@zioproto zioproto commented Oct 2, 2024

Description

The goal is of this volume mount was to translate usernames from ids. However this is not really necessary, and exposes the full content of the passwd and group file from the host to the container. Moreover, on systems like MacOS where docker runs into an internal Linux VM, the content of the file /etc/passwd is completely irrelevant.

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

The goal is of this volume mount was to translate usernames from ids. However this is not really necessary, and exposes the full content of the passwd and group file from the host to the container.
Moreover, on systems like MacOS where docker runs into an internal Linux VM, the content of the file /etc/passwd is completely irrelevant.
@matt-FFFFFF matt-FFFFFF merged commit 06db5cf into Azure:main Oct 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants