Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform Resiliency Updates #306

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Terraform Resiliency Updates #306

merged 7 commits into from
Jun 27, 2024

Conversation

jchancellor-ms
Copy link
Contributor

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

This PR adds several resiliency and currency updates:

  • Sets default gateway sku's to a zone redundant version
  • Sets public IP addresses to Standard, Static, with all 3 zones represented as defaults
  • Added Delete locks to all private cloud implementations
  • Updates the AzureRM and AzAPI minimum versions
  • Converts static password entry on the greenfield module to an autogenerated value stored as a key vault secret.

Breaking Changes

Testing Evidence

image

As part of this Pull Request I have

  • [x ] Checked for duplicate Pull Requests
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [x ] Performed testing and provided evidence.
  • [ x] Updated relevant and associated documentation.

@jchancellor-ms
Copy link
Contributor Author

Finished testing and the code runs clean now -
image

Copy link
Contributor

@vivalada vivalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vivalada vivalada merged commit 9188f97 into main Jun 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants