Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

VM queries added #61

Merged
merged 11 commits into from
Sep 14, 2023
Merged

VM queries added #61

merged 11 commits into from
Sep 14, 2023

Conversation

ReneHezser
Copy link
Contributor

Overview/Summary

Added 2 Resource Graph Queries for VMs.

This PR fixes/adds/changes/removes

none

Breaking Changes

none

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

rodrigosantosms
rodrigosantosms suggested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@rodrigosantosms rodrigosantosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments for each file.

docs/content/services/networking/load-balancer/code/lb-2/lb-2.kql Show resolved Hide resolved
docs/content/services/storage/storage-Account/_index.md Show resolved Hide resolved
docs/content/services/compute/virtual-machines/code/vm-19/vm-19.kql Show resolved Hide resolved
docs/content/services/compute/virtual-machines/code/vm-20/vm-20.kql Show resolved Hide resolved
@ReneHezser
Copy link
Contributor Author

Please see comments for each file.

Thanks for the comments. I've updated queries accordingly.

lachaves
lachaves approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@lachaves lachaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran hugo server, reviewed the content. Everything looks good.

lachaves
lachaves approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@lachaves lachaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodrigosantosms rodrigosantosms merged commit e6c51ad into Azure:main Sep 14, 2023
4 checks passed
@ReneHezser ReneHezser deleted the Compute-Updates branch September 14, 2023 06:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rodrigosantosms rodrigosantosms rodrigosantosms approved these changes

@lachaves lachaves lachaves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ReneHezser @rodrigosantosms @lachaves