Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

added Cosmos DB guidance #53

Merged
merged 6 commits into from
Jul 7, 2023
Merged

added Cosmos DB guidance #53

merged 6 commits into from
Jul 7, 2023

Conversation

kovarikthomas
Copy link
Contributor

Overview/Summary

This PR adds service guidance for Azure Cosmos DB. The guidance has been reviewed and approved by engineering.

Related ADO item id: 27706

This PR fixes/adds/changes/removes

  1. Adds service guidance for Azure Cosmos DB

Breaking Changes

None

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@lachaves
Copy link
Contributor

lachaves commented Jul 4, 2023

@kovarikthomas, can you please fix some "Wrong line endings" and "Trailing whitespace" errors reported by lint code check.

@kovarikthomas
Copy link
Contributor Author

@lachaves That's done, all linting checks are passing now.

@lachaves
Copy link
Contributor

lachaves commented Jul 7, 2023

@kovarikthomas, I was able to run hugo server and validate content and links.
The only thing we need to change is the State, as we are using only Preview for now (not using Verified for now). Can you please change the state for all from Verified to Preview so we can approve, merge and close?

@kovarikthomas
Copy link
Contributor Author

@lachaves I have reverted all states to preview. Please approve and merge. Thanks!

Copy link
Contributor

@lachaves lachaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran hugo server, validated links, content, looks good to me.

@lachaves lachaves merged commit 48cd813 into Azure:main Jul 7, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants