Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

agw-8 - add query #414

Merged
merged 4 commits into from
Apr 5, 2024
Merged

agw-8 - add query #414

merged 4 commits into from
Apr 5, 2024

Conversation

ReneHezser
Copy link
Contributor

@ReneHezser ReneHezser commented Mar 28, 2024

Overview/Summary

Adds Resource Graph Query for the recommendation

image

Related Issues/Work Items

AB#32806

This PR fixes/adds/changes/removes

  1. adds recommendation query

Breaking Changes

none

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries and/or scripts
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@ReneHezser ReneHezser requested review from a team as code owners March 28, 2024 09:44
@ejhenry ejhenry added Area: Resource Graph Query(s) Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team labels Mar 28, 2024
@Monte-Hazboun
Copy link
Contributor

Hi René,

Shouldn't the query be reversed and only show up as an affected resource if connection draining is not enabled? The connection draining property is a null if it's not turned on, so swap line 5 to check for null and adjust the parameter to show connection draining is disabled.

Copy link
Contributor

@rodrigosantosms rodrigosantosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the recommended changes and approved

@rodrigosantosms rodrigosantosms enabled auto-merge (squash) April 5, 2024 15:09
@oZakari oZakari disabled auto-merge April 5, 2024 15:45
@oZakari oZakari merged commit 89cfa98 into Azure:main Apr 5, 2024
4 checks passed
@ReneHezser ReneHezser deleted the agw-8 branch April 8, 2024 05:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants