Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

APIM -APRL recommendation #346

Merged
merged 6 commits into from
Apr 5, 2024
Merged

APIM -APRL recommendation #346

merged 6 commits into from
Apr 5, 2024

Conversation

aarthiem
Copy link
Contributor

@aarthiem aarthiem commented Mar 15, 2024

Overview/Summary

APIM -APRL recommendation for stv2 APIM upgrades

Related Issues/Work Items

https://dev.azure.com/CSUSolEng/Well-Architected%20Framework/_workitems/edit/29872

  • To associate a GitHub Issue, use a key word preceded with the GitHub issue number.
  • To associate an ADO Work Item, use the key word AB# succeeded with the ADO Work Item ID.

This PR fixes/adds/changes/removes

  1. adds recommendation for stv2 APIM upgrades

Breaking Changes

  1. NA

As part of this Pull Request I have

  • [ x] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [x ] Checked for duplicate Pull Requests
  • [ x] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [ x] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [x ] Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries and/or scripts
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@aarthiem aarthiem requested a review from a team as a code owner March 15, 2024 20:48
@ejhenry
Copy link
Contributor

ejhenry commented Mar 15, 2024

Thanks for the contribution @aarthiem! Are you able to work through the failed linting check or do you need help with that?

@ejhenry ejhenry added Area: Service Guidance Improvements or additions to documentation Area: Resource Graph Query(s) labels Mar 15, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Mar 16, 2024

@aarthiem - I resolved the linting issues. Can you include in the PR a screenshot of the successful testing of your ARG query?

Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aarthiem - Please update the summary table to include the new recommendation.

I suggested a category from the allowed list in the contribution guide. If you think one of the other options would be a better fit, please change to that.

Also, please include a screenshot of the successful testing of your query.

docs/content/services/integration/api-management/_index.md Outdated Show resolved Hide resolved
add recommendation to summary
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for screenshot as discussed, but otherwise looks good!

@aarthiem
Copy link
Contributor Author

aarthiem commented Apr 4, 2024

image
Screenshot 2024-04-04 192639
@ejhenry @edknox @oZakari - Please check the screenshot here.

@oZakari oZakari merged commit dfe7fee into Azure:main Apr 5, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants