Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

US 32392 Fix Queries for AFD 1 AFD 10 and AFD 11 #319

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

didayal-msft
Copy link
Contributor

@didayal-msft didayal-msft commented Mar 8, 2024

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

Related Issues/Work Items

AB#32392 Azure Front Door - APRL ARG Query Quality Improvement

This PR fixes/adds/changes/removes

AFD-1 - Avoid combining Traffic Manager and Front Door

This query lists out all traffic manager profiles where endpoint target value is equal to the azure front door endpoint name or azure front door custom domain name.

This works on the premise that traffic manager and front door can only be combined if traffic manager endpoint type is "external" (azure endpoint and nested endpoint being the other 2) and value is equal to AFD endpoint or custom domain.

If this is not the right premise, please help me with a pattern on how TM and AFD can be combined, and I will correlate using ARG.

image

AFD-10 - Enable the WAF
The query shows AFDs with no security policies or where there are no managed rules (which will automatically include standard skus).
image

AFD-11 - Disable health probes when there is only one origin in an origin group

Query shows AFDs with single origin and active health probe.
image

As part of this Pull Request I have

  • [ x] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [ x] Checked for duplicate Pull Requests
  • [ x] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [ x] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • [x ] Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries and/or scripts
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@didayal-msft didayal-msft requested review from a team as code owners March 8, 2024 16:29
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @didayal-msft. Please include screenshots of your test results for each query.

@didayal-msft
Copy link
Contributor Author

didayal-msft commented Mar 8, 2024

Thanks for the contribution @didayal-msft. Please include screenshots of your test results for each query.

@ejhenry Updated original post with screenshots

@ejhenry
Copy link
Contributor

ejhenry commented Mar 10, 2024

@Azure/aprl-networking please review and compare with #318

@ejhenry ejhenry mentioned this pull request Mar 10, 2024
@didayal-msft didayal-msft marked this pull request as draft March 11, 2024 13:52
@oZakari oZakari added the Needs: Attention from aprl-admins 👋 Needs attention from aprl-admins GitHub team. label Mar 11, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Mar 18, 2024

@Azure/aprl-networking please review

@oZakari oZakari added Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team and removed Needs: Attention from aprl-admins 👋 Needs attention from aprl-admins GitHub team. labels Mar 19, 2024
@oZakari
Copy link
Contributor

oZakari commented Mar 27, 2024

Hey @didayal-msft, just checking as I see this PR is in a draft state, are you going to be adding stuff or can you set the PR ready to review if applicable.

@didayal-msft didayal-msft marked this pull request as ready for review March 28, 2024 13:26
@didayal-msft
Copy link
Contributor Author

didayal-msft commented Mar 28, 2024

Hey @didayal-msft, just checking as I see this PR is in a draft state, are you going to be adding stuff or can you set the PR ready to review if applicable.

@oZakari sorry left it in draft. No changes and this is ready for review.

@maheshbenke maheshbenke added Needs: Attention from aprl-admins 👋 Needs attention from aprl-admins GitHub team. and removed Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team labels Apr 4, 2024
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@didayal-msft really nice work on these queries. I've just updated the summary table for the new queries but LGTM

@oZakari oZakari merged commit 7dbd12b into Azure:main Apr 4, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants