Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Recommendations Added for Compute, Governance and Migration#2 #128

Merged
merged 24 commits into from
Oct 28, 2023

Conversation

Poven795909
Copy link
Contributor

Overview/Summary

This pull request includes recommendations under Compute, Governance and Migration service category.

Related Issues/Work Items

AB#30083
AB#29842
AB#29818
AB#29819
AB#30082

This PR fixes/adds/changes/removes

  1. Updates the ARG query for Infra - Migration - Backup - Classic alerts as suggested in previous PR.
  2. Updates the ARG query for Infra - Monitoring - Log Analytics - Log-5 recommendation to conform with the Standards specified in https://azure.github.io/Azure-Proactive-Resiliency-Library/contributing/#automation-standards-for-recommendations
  3. Adds a new service category "Governance" and includes recommendations for Automation account.
  4. Adds a new service "Compute gallery" under "Compute" gallery and includes recommendations for it along with ARG queries.
  5. Adds a new service "Azure Site Recovery" under "Compute" gallery and includes recommendations for it.

Breaking Changes

NA

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@oZakari
Copy link
Contributor

oZakari commented Oct 23, 2023

@Poven795909 I opened a PR against your repo to adjust some folder names but once you approve that we can go ahead and close. Thank you!

@oZakari oZakari removed the request for review from lachaves October 28, 2023 01:04
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contributions for this!

@oZakari oZakari merged commit 4b87b49 into Azure:main Oct 28, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants