Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

UserStory30177-Monitoring-LogAnalytics #109

Closed
wants to merge 2 commits into from

Conversation

Poven795909
Copy link
Contributor

Overview/Summary

Added missing guidance as specified in https://dev.azure.com/CSUSolEng/Well-Architected%20Framework/_workitems/edit/30177

This PR fixes/adds/changes/removes

  1. Adds a recommendation under Azure services>Monitoring>LogAnalytics
  2. Adds a KQL query for the above recommendation

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Copy link
Contributor

@lachaves lachaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes/additions. Ran hugo server and everything looks good.

Copy link
Contributor

@lachaves lachaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content was checked, I ran hugo server and confirmed the expected changes.
There is one automatic check failing and it is because a linter check, an additional new line I believe.
Can you please remove the extra new line at line 146 , just before Resources for Log-5, I believe this is causing the error.
After this it will be ready for approving and merging.

@Poven795909
Copy link
Contributor Author

Will do the changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants