Merging recommendation and fixing query

Azure · Aug 4, 2023 · 9c2e8ee · 9c2e8ee
1 parent 2af9eed
commit 9c2e8ee
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 11 deletions.
diff --git a/docs/content/services/storage/storage-Account/_index.md b/docs/content/services/storage/storage-Account/_index.md
@@ -23,7 +23,6 @@ The below table shows the list of resiliency recommendations for Storage Account
 |[ST-5 - Enable soft delete for recovery of data](#st-5---enable-soft-delete-for-recovery-of-data)                                                      |  Medium  | Preview  |         No          |
 |[ST-6 - Enable version for accidental modification](#st-6---enable-version-for-accidental-modification)                                                |  Medium  | Preview  |         No          |
 |[ST-7 - Enable point and time restore for containers for recovery](#st-7---enable-point-and-time-restore-for-containers-for-recovery)                  |   Low    | Preview  |         No          |
-|[ST-8 - Keep versioning below 100 for performance](#st-8---keep-versioning-below-1000-for-performance)                                                 |   Low    | Preview  |         No          |
 |[ST-9 - Configure Diagnostic Settings for all Azure Resources](#st-9---Configure-Diagnostic-Settings-for-all-Azure-Resources)                                                 |   Low    | Preview  |         No          |
 
 {{< /table >}}
@@ -157,12 +156,14 @@ Soft delete option allow for recovering data if its deleted by mistaken. Moreove
 
 **Recommendation/Guidance**
 
-to recover data from accidental modification, enable versioning.
+To recover data from accidental modification or deletion enable versioning.
+Having a large number of versions per blob can increase the latency for blob listing operations. Microsoft recommends maintaining fewer than 1000 versions per blob. You can use lifecycle management to automatically delete old versions.
 
 **Resources**
 
 - [Blob versioning](https://learn.microsoft.com/azure/storage/blobs/versioning-overview )
 
+
 **Resource Graph Query/Scripts**
 
 {{< collapse title="Show/Hide Query/Script" >}}
@@ -196,7 +197,7 @@ Point and time restore support general purpose v2 account in standard performanc
 
 <br><br>
 
-### ST-8 - Keep versioning below 1000 for performance
+
 
 **Impact: Low**
 

diff --git a/docs/content/services/storage/storage-Account/code/st-1/st-1.kql b/docs/content/services/storage/storage-Account/code/st-1/st-1.kql
@@ -1 +1,5 @@
-resources| where type =='microsoft.storage/storageaccounts' |project name, sku
+Resources | where type =~'microsoft.storage/storageaccounts'
+| where sku.name =~'Standard_LRS' or sku.name =~ 'Standard_ZRS'
+| project recommendationId = 'st-1', name, id, redundancy=sku.name
+
+
diff --git a/docs/content/services/storage/storage-Account/code/st-2/st-2.kql b/docs/content/services/storage/storage-Account/code/st-2/st-2.kql
@@ -1,2 +1,3 @@
-resources
-| where type == "microsoft.classicstorage/storageaccounts"
+"resources
+| where type =~ 'microsoft.classicstorage/storageaccounts'
+| project recommendationId = 'st-2', name, id, type"
diff --git a/docs/content/services/storage/storage-Account/code/st-3/st-3.kql b/docs/content/services/storage/storage-Account/code/st-3/st-3.kql
@@ -1 +1,3 @@
-under development
+Resources | where type =~'microsoft.storage/storageaccounts'
+| where isnull(properties.accessTier)
+| project recommendationId = 'st-3', name, id, accessTier="not defined - GeneralPurpose V1
diff --git a/docs/content/services/storage/storage-Account/code/st-8/st-8.kql b/docs/content/services/storage/storage-Account/code/st-8/st-8.kql
@@ -1,4 +1 @@
-//Set variable values to approroriate storage account and resource group
-$storageAccount = "StorageAccountName"
-$resourceGroupName='ResourceGroupName'
-Get-AzStorageBlobServiceProperty -ResourceGroupName $resourceGroupName -StorageAccountName $storageAccount
+