Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude master DB from active geo rep recommendation #468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jdmsoss
Copy link
Contributor

@jdmsoss jdmsoss commented Oct 17, 2024

Overview/Summary

Master database should be excluded from "Use Active Geo Replication to Create a Readable Secondary in Another Region" recommendation result.

Before my fix 👇

active-geo-rep-before

After my fix 👇

active-geo-rep-after

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@jdmsoss jdmsoss requested a review from a team as a code owner October 17, 2024 15:01
@microsoft-github-policy-service microsoft-github-policy-service bot added the Bug 🐞 Something isn't working label Oct 17, 2024
@oZakari oZakari added the PR: Safe to Test ARG Queries 🧪 Confirmation to allow testing of ARG queries label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working PR: Safe to Test ARG Queries 🧪 Confirmation to allow testing of ARG queries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants