Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Oracle odaa sections #463

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

basimolimajeed
Copy link
Contributor

Overview/Summary

APRL input for oracle ODAA. Added both as specialized workload and in the resources section

Related Issues/Work Items

N/A

Breaking Changes

N/A

As part of this pull request I have

  • [ x] Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [ x] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [ x] Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@basimolimajeed basimolimajeed requested a review from a team as a code owner October 13, 2024 07:40
@basimolimajeed basimolimajeed changed the title Oracle odaa feat: New Oracle odaa sections Oct 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Oct 13, 2024
@oZakari oZakari added Area: Resource Guidance 📝 Improvements or additions to documentation Area: Resource Graph Query(s) #️⃣ Related to ARG queries PR: Safe to Test ARG Queries 🧪 Confirmation to allow testing of ARG queries labels Oct 16, 2024
@oZakari oZakari requested a review from a team as a code owner October 16, 2024 17:25
@oZakari oZakari force-pushed the Oracle-ODAA branch 2 times, most recently from 3df7c25 to 0901d88 Compare October 16, 2024 18:21
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments about architectural guidance vs specific configurations that affect resiliency.

@@ -0,0 +1,201 @@
- description: Implement a regional replication strategy for Oracle to meet your workload requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be more architectural guidance than a configuration for the Oracle resource that can be configured to improve the resiliency of the Oracle resource deployment. As such, wouldn't this better be addressed through WAF guidance?

recommendationResourceType: Specialized.Workload/oracle
recommendationMetadataState: Active
longDescription:
Regional replication is a key strategy to ensure business continuity and disaster recovery for your Oracle workloads. Implement a regional replication strategy to meet your workload requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be more architectural guidance than a configuration for the Oracle resource that can be configured to improve the resiliency of the Oracle resource deployment. As such, wouldn't this better be addressed through WAF guidance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendation is agreed by relevant teams and as such we would like to keep it

url: "https://docs.oracle.com/en/database/oracle/oracle-database/21/haovw/db-azure1.html#GUID-91572193-DF8E-4D7A-AF65-7A803B89E840"


- description: Implement a strategy for resiliency that is tailored to your Oracle workload requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be more architectural guidance than a configuration for the Oracle resource that can be configured to improve the resiliency of the Oracle resource deployment. As such, wouldn't this better be addressed through WAF guidance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendation is agreed by relevant teams and as such we would like to keep it

- name: Oracle Database@Azure Evaluations by Oracle MAA
url: "https://docs.oracle.com/en/database/oracle/oracle-database/21/haovw/db-azure1.html#GUID-91572193-DF8E-4D7A-AF65-7A803B89E840"

- description: Implement a backup and restore strategy for Oracle databases to meet your workload requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be more architectural guidance than a configuration for the Oracle resource that can be configured to improve the resiliency of the Oracle resource deployment. As such, wouldn't this better be addressed through WAF guidance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendation is agreed by relevant teams and as such we would like to keep it. Please reach on Teams if you need further discussion with the relevant team experts. thanks

- name: Learn about Oracle Maximum Availability Architecture for Oracle Database@Azure
url: "https://docs.oracle.com/en/solutions/oracle-maa-db-at-azure/#GUID-7723E2B1-9588-40BC-88BE-44637B1AF0D9"

- description: Scale up the VM cluster based on the workload requirement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this might be better stated in terms of monitoring the VM cluster and scaling based on alerting on thresholds set via monitoring.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will discuss with the experts

- name: Learn about Oracle Maximum Availability Architecture for Oracle Database@Azure
url: "https://docs.oracle.com/en/solutions/oracle-maa-db-at-azure/#GUID-7723E2B1-9588-40BC-88BE-44637B1AF0D9"

- description: Plan and implement IP addressing strategy to meet current and future requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be more architectural guidance than a configuration for the Oracle resource that can be configured to improve the resiliency of the Oracle resource deployment. As such, wouldn't this better be addressed through WAF guidance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendation is agreed by relevant teams and as such we would like to keep it

- name: Plan for IP Address Space
url: "https://docs.oracle.com/en-us/iaas/Content/database-at-azure/oaa_ip.htm"

- description: Only one ODAA delegated subnet must exist within the VNet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari closed this Oct 16, 2024
@oZakari oZakari reopened this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Area: Resource Guidance 📝 Improvements or additions to documentation Enhancement 🆕 New feature or request PR: Safe to Test ARG Queries 🧪 Confirmation to allow testing of ARG queries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants