Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIM recommendations are PG verified now and updates for stv1 retirement #443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aarthiem
Copy link
Contributor

@aarthiem aarthiem commented Oct 2, 2024

Overview/Summary

This PR includes updates to stv1 retirement date and all apim recommendations are PG verified now, so the flag is set to true.

Related Issues/Work Items

Breaking Changes

  1. Replace me
  2. Replace me

As part of this pull request I have

  • [x ] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [ x] Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [x ] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [ x] Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@aarthiem aarthiem requested a review from a team as a code owner October 2, 2024 02:44
@oZakari oZakari added the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Oct 7, 2024
@oZakari
Copy link
Collaborator

oZakari commented Oct 7, 2024

Hi @aarthiem, thanks for the PR, can you please take a look at the failed tests? Looks like the length of the description for one of your recommendations is too long and the PR title needs to be adjusted.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity label Oct 15, 2024

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants