Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack: Add shim for 13.9+ to prevent Jetpack_SSO fatal and admin notices for 13.5+ #5937

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Jetpack: Add shim for 13.9+ to prevent Jetpack_SSO fatal and admin notices for 13.5+ #5937

merged 5 commits into from
Oct 16, 2024
+36 −0

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented Oct 16, 2024 •
edited
Loading

Description

Change introduced here for 13.9: Automattic/jetpack-production@32a21ee#diff-7e14e5575ebceead3f7e1bb047e5e5b96586af6e828aac63ce77fa0ca48945c4L28

Changelog Description

Added

  • Jetpack 13.5+: Display admin notice for users using deprecated standalone plugin

Fixed

  • Jetpack 13.9+: Add shim for users using deprecated standalone plugin to prevent fatal errors

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rebeccahum rebeccahum marked this pull request as ready for review October 16, 2024 18:48
@rebeccahum rebeccahum requested a review from a team as a code owner October 16, 2024 18:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rebeccahum rebeccahum merged commit bf7cc95 into develop Oct 16, 2024
11 of 33 checks passed
@rebeccahum rebeccahum deleted the jetpack-13.9-sso-hotfix branch October 16, 2024 20:15
rebeccahum added a commit that referenced this pull request Oct 16, 2024
@rebeccahum
Jetpack: Add shim for 13.9+ to prevent Jetpack_SSO fatal and admin no…
07be9c7 
…tices for 13.5+ (#5937)

* Jetpack: Add shim for 13.9+ to prevent Jetpack_SSO fatal and admin notice for 13.5+

* Need to extend the darn class to prevent undefined method fatals

* use Capability Condition

* Revert "use Capability Condition"

This reverts commit f441783.

* remove condition since it is super admin by default if no cap condition specified
rebeccahum added a commit that referenced this pull request Oct 16, 2024
@rebeccahum
Jetpack: Add shim for 13.9+ to prevent Jetpack_SSO fatal and admin no…
5dd8415 
…tices for 13.5+ (#5937)

* Jetpack: Add shim for 13.9+ to prevent Jetpack_SSO fatal and admin notice for 13.5+

* Need to extend the darn class to prevent undefined method fatals

* use Capability Condition

* Revert "use Capability Condition"

This reverts commit f441783.

* remove condition since it is super admin by default if no cap condition specified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinatkhaziev rinatkhaziev rinatkhaziev approved these changes

Assignees
No one assigned
Labels
[Component] Jetpack ChangelogTagID: 636069
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebeccahum @rinatkhaziev