Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modules:false to babel.config.js to allow tree shaking #448

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

kat3samsin
Copy link
Contributor

@kat3samsin kat3samsin commented Oct 15, 2024

Description

Fix to reduce VIP Auth web bundle size. This enables tree shaking specifically for react-icons.

Checklist

  • This PR has good automated test coverage
  • The storybook for the component has been updated

Steps to Test

Outline the steps to test and verify the PR here.

Example:

  1. Pull down PR.
  2. npm run dev.
  3. Open Storybook.
  4. Eat cookies.
  5. Verify cookies are delicious.

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for vip-design-system-components ready!

Name Link
🔨 Latest commit 11f7b7d
🔍 Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/6710604a926e170008555eff
😎 Deploy Preview https://deploy-preview-448--vip-design-system-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant